Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcpedit - add dlt plugin sllv2 #841

Closed

Conversation

GabrielGanne
Copy link
Contributor

Hi,

This adds support for V2 version of SLL.
Most of it is the same as v1 and I tried to keep the same names anyway.
Please have a look, maybe you'll want me to factorize some stuff ... I didn't because I find the code most simple that way.

ref: SLLV2: https://www.tcpdump.org/linktypes/LINKTYPE_LINUX_SLL2.html

@GabrielGanne
Copy link
Contributor Author

Hi,
It seems cpp-linter fails because it cannot find plugins_types.h include.
Is it possible this is some configuration issue ? The normal build works fine.
BR,

@fklassen fklassen changed the title tcpedit - add dlt plugin sslv2 tcpedit - add dlt plugin sllv2 Jun 1, 2024
@fklassen fklassen changed the base branch from master to PR_#841_add_DLT_SLLv2_staging June 1, 2024 17:49
@fklassen
Copy link
Member

fklassen commented Jun 1, 2024

Thanks for the PR. This appears to be a duplicate of #727. I am still creating a PR and looking a conflicts to see if there are any improvements that can be brought in by this work.

I believe linter issues will be resolved once rebased off 4.5.0 branch. I'll investigate.

@fklassen
Copy link
Member

fklassen commented Jun 1, 2024

Closing as duplicate of #727 / #820

@fklassen fklassen closed this Jun 1, 2024
@GabrielGanne GabrielGanne deleted the sllv2 branch October 14, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants