This repository was archived by the owner on Jan 23, 2019. It is now read-only.
Beautify log #8
Merged
Beautify log #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pkg/server/server.go
sadlil
suggested changes
Jan 24, 2017
| @@ -72,7 +72,7 @@ func TestClientDoCron(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestClientDoAt(t *testing.T) { | |||
| handle, err := client.DoAt("scheduledJobTest", 1484160580, []byte("test data")) | |||
| handle, err := client.DoAt("scheduledJobTest", 1784161581, []byte("test data")) | |||
There was a problem hiding this comment.
Better use
time.Now().Add(duration).Unix()
| @@ -57,11 +57,11 @@ func (s *Server) loadAllJobs() { | |||
| log.Error(err) | |||
| return | |||
| } | |||
|
|
|||
| log.Debugf("%+v", jobs) | |||
| log.Debugln("....................loading job.........................") | |||
There was a problem hiding this comment.
those lines are not log lines. remove those unnecessary line. this doesn't revel any information.
| @@ -72,11 +72,13 @@ func (s *Server) loadAllCronJobs() { | |||
| log.Error(err) | |||
| return | |||
| } | |||
| log.Debugf("load scheduled job: %+v", schedJobs) | |||
| log.Debugln("......................loading cron job.......................") | |||
| for { | ||
| select { | ||
| case <-ticker.C: | ||
| cjs, err := s.store.GetCronJobs() |
There was a problem hiding this comment.
stop DB access. read from cron status or gearman status.
sadlil
approved these changes
Jan 25, 2017
tamalsaha
added a commit
that referenced
this pull request
Jul 6, 2017
4cca445 Update libbuild.py 447ab55 Update reimport.py 47a901a Update reimport.py 6b850ad Update libbuild.py 3ae7f19 Allow reproducible build for tagged builds. (#10) 7b8361c Update reimport list 44e6f2e Update import list fd2a39a Create reimport.py 4e1e0c2 Update reimport list fe1a5bb Update client-go pkg map 64ff92c Change package imports of GO source files (#9) e73efa5 Treat release-* branches like master (#8) 0ad6a1a Retry docker push for attic until successful 99315db Delete docker image from Docker Hub for a given tag (#7) 97a4163 Rename k8sdb to kubedb 454a94f Support globs for ungrouping imports d6d6779 Avoid adding .exe when uploading file. 9306596 Use $DOCKER_REGISTRY in build command f2b13fe Load lib.sh from project specific files. cf9de3a Introduce DOCKER_REGISTRY env variable (#4) a512ccd Move project specific docker methods to their own files. (#3) f46deb7 Add k8sdb & cowrypay scripts. (#2) 3313b96 Skip files for update_registry ef11790 Add dot env for loading ENV vars (#1) 5837743 Add default list of deps 1e2eda3 Fix write_json. 7fb3825 Update README.md 765a9c7 Print message indicating current file/dir worked on. 97853a2 Fix fn name 06384a1 Add ungroup_go_imports 5d6aa3f Set version linker vars only if enabled. git-subtree-dir: hack/libbuild git-subtree-split: 4cca4459d445d27086af5c57f619121fe02dd059
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.