Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/device code flow #78

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Feature/device code flow #78

wants to merge 9 commits into from

Conversation

lucafabbri
Copy link

No description provided.

@lucafabbri
Copy link
Author

Device Authorization Flow was missing and as I need it for a project I decided to send you this PR with necessary implementation for this flow.

@lucafabbri
Squashed commit of the following:
2058f6e 
commit 2fc190c
Author: Luca Fabbri <[email protected]>
Date:   Tue Feb 14 19:11:44 2023 +0100

    Update README.md

commit fdfca43
Author: Luca Fabbri <[email protected]>
Date:   Tue Feb 14 19:04:07 2023 +0100

    Update openid.dart

commit 1aacec3
Merge: 2f513f3 985b678
Author: Luca Fabbri <[email protected]>
Date:   Tue Feb 14 10:10:41 2023 +0100

    Merge branch 'feature/device-code-flow' of https://github.com/lucafabbri/openid_client into feature/device-code-flow

commit 985b678
Author: lfabbri <[email protected]>
Date:   Mon Feb 13 20:36:16 2023 +0100

    Device Authoriation Flow

commit 2f513f3
Author: lfabbri <[email protected]>
Date:   Mon Feb 13 20:36:16 2023 +0100

    wip
@lucafabbri
Copy link
Author

Any change you will evaluate this improvement?

rbellens
rbellens requested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@rbellens rbellens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove all changes related to formatting. It is hard to evaluate the things that actually changed when so many code lines have changed.

@lucafabbri
Copy link
Author

hi @rbellens i made the changes requested

@lucafabbri
Copy link
Author

@rbellens any news on merging this feature
Should you need help mantain the repo we are welcome to provide support ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbellens rbellens rbellens requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucafabbri @rbellens