Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template for HttpCheck alert configuration #499

Closed
wants to merge 13 commits into from
Closed

Add template for HttpCheck alert configuration #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
bc991ee
replace hardcoded for: value in alert:HttpCheck
martini-source Jan 18, 2024
b83f56e
use parentheses to check for non existent members
martini-source Jan 18, 2024
127bbf8
bump stardog chart version
martini-source Jan 18, 2024
fe50c12
make docs
martini-source Jan 18, 2024
55247a8
add alerts.httpCheck.for to values.yaml
martini-source Jan 18, 2024
04c3d1a
remove quoting of 'for' value
martini-source Jan 18, 2024
4af45b6
add quotationmarks around template
martini-source Jan 18, 2024
8e21827
revert last commit
martini-source Jan 18, 2024
3db6246
use if/else instead
martini-source Jan 18, 2024
453c8cf
change default value to 1m
martini-source Jan 18, 2024
293b52a
set default value to empty
martini-source Jan 18, 2024
7331bbc
Update stardog-rules.yaml
martini-source Jan 18, 2024
28aed83
add parentheses to guard against nested undefined
martini-source Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ helm repo add appuio https://charts.appuio.ch
| [![chart downloads](https://img.shields.io/github/downloads/appuio/charts/secret-1.1.0/total)](https://github.com/appuio/charts/releases/tag/secret-1.1.0) | [secret](appuio/secret/README.md) |
| [![chart downloads](https://img.shields.io/github/downloads/appuio/charts/signalilo-0.12.1/total)](https://github.com/appuio/charts/releases/tag/signalilo-0.12.1) | [signalilo](appuio/signalilo/README.md) |
| [![chart downloads](https://img.shields.io/github/downloads/appuio/charts/snappass-1.0.0/total)](https://github.com/appuio/charts/releases/tag/snappass-1.0.0) | [snappass](appuio/snappass/README.md) |
| [![chart downloads](https://img.shields.io/github/downloads/appuio/charts/stardog-0.23.1/total)](https://github.com/appuio/charts/releases/tag/stardog-0.23.1) | [stardog](appuio/stardog/README.md) |
| [![chart downloads](https://img.shields.io/github/downloads/appuio/charts/stardog-0.24.0/total)](https://github.com/appuio/charts/releases/tag/stardog-0.24.0) | [stardog](appuio/stardog/README.md) |
| [![chart downloads](https://img.shields.io/github/downloads/appuio/charts/stardog-userrole-operator-0.2.3/total)](https://github.com/appuio/charts/releases/tag/stardog-userrole-operator-0.2.3) | [stardog-userrole-operator](appuio/stardog-userrole-operator/README.md) |
| [![chart downloads](https://img.shields.io/github/downloads/appuio/charts/trifid-2.0.2/total)](https://github.com/appuio/charts/releases/tag/trifid-2.0.2) | [trifid](appuio/trifid/README.md) |

Expand Down
2 changes: 1 addition & 1 deletion appuio/stardog/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
name: stardog
version: 0.23.1
version: 0.24.0
appVersion: 9.2.1
description: Stardog is the world’s leading knowledge graph platform for the enterprise. Stardog makes it fast and easy to turn enterprise data into knowledge.
home: "https://www.stardog.com/"
Expand Down
2 changes: 1 addition & 1 deletion appuio/stardog/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# stardog

![Version: 0.23.1](https://img.shields.io/badge/Version-0.23.1-informational?style=flat-square) ![AppVersion: 9.2.1](https://img.shields.io/badge/AppVersion-9.2.1-informational?style=flat-square)
![Version: 0.24.0](https://img.shields.io/badge/Version-0.24.0-informational?style=flat-square) ![AppVersion: 9.2.1](https://img.shields.io/badge/AppVersion-9.2.1-informational?style=flat-square)

Stardog is the world’s leading knowledge graph platform for the enterprise. Stardog makes it fast and easy to turn enterprise data into knowledge.

Expand Down
2 changes: 1 addition & 1 deletion appuio/stardog/templates/monitoring/stardog-rules.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ spec:
{{- if .Values.ingress.enabled }}
- alert: HttpCheck
expr: probe_success{instance="https://{{ .Values.ingress.host }}/admin/healthcheck"} != 1
for: 1m
for: {{ default "1m" (((.Values.alerts).httpCheck).for) | quote }}
annotations:
summary: Http check failed
description: "Http check failed on {{ "{{" }} $labels.instance {{ "}}" }}"
Expand Down
4 changes: 3 additions & 1 deletion appuio/stardog/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,9 @@ metrics:
repository: sscaling/jmx-prometheus-exporter
tag: 0.12.0
pullPolicy: IfNotPresent

alerts:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will apply the "30m" value to all environments that use this helm chart. I don't think this is what we want?

This value should only be set in the repo which invokes this chart.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, done.

httpCheck:
for:
resources: {}

nodeSelector: {}
Expand Down
Loading