stardog: Unset custom scrape interval #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current interval of 3s is quite idiotic; there is no real value in scraping data every 3 seconds if in the end you're more interested in data over a day or so. This commit - removes the value by default, which will cause the scrapeconfig to use the default value configured in Prometheus' global config - allows us to overwrite the interval and timeouts via values Signed-off-by: Manuel Hutter <[email protected]>
martini-source
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The current interval of 3s is quite idiotic; there is no real value in scraping data every 3 seconds if in the end you're more interested in data over a day or so.
This commit
Checklist
make docschart/<chart-name>[
bug,enhancement,documentation,change,breaking,dependency]