-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix not being able to edit Billing members #535
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
e0ed583
to
e4c90e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added @bastjan as a reviewer for this. From a priority perspective, this is not urgent. The cause, triggering this, is unlikely to happen within the next days(/weeks).
There will still be cases where a We might add some reconciling logic for the roles but would prefer to correct the rules here until we have smth like this. See for correct rules: |
This comment was marked as outdated.
This comment was marked as outdated.
e4c90e9
to
182d860
Compare
This comment was marked as outdated.
This comment was marked as outdated.
182d860
to
e1b2a49
Compare
This comment was marked as outdated.
This comment was marked as outdated.
@corvus-ch @bastjan I don't quite understand what the holdup is for this fix. |
As i said: there is no reconciliation and no guarantee that the admin role is created if an existing, wrongly setup BE is enabled/fixed. We still need the admin role creation for VSHN support team members. I'd strongly prefer to update the role creation code with the rules i linked. |
Ok, leaving this for now. Let me know if you prefer to disable this view temporarily, so that users can't click/visit the BE members list view. |
This comment was marked as outdated.
This comment was marked as outdated.
I might misunderstand the issue. Why not just create the roles as defined here? #535 (comment) |
As far as I understand, this issue does not surface when users create their BillingEntity on their own. Only when they get created in the ERP. So, this is not an issue to expect within the next days. Instead of wasting time with some workarounds (which we might have to remove again later) in the frontend, I would prefer to fix this for good in the API. |
As far as I have just tested, this issue does in fact surface for user-created BillingEntities as well. I just created a billingentity through the portal (using a new account created through social login), and subsequently when I click on "edit members", the issue described above pops up (error message + glitchtip popup). So it is not as uncommon as we initially thought. |
🚀 Preview deployment active
To uninstall this deployment, close or merge this PR. |
Summary
v0.24 of control-api has been released, which creates automatically the admin cluster role for billing entities when created. This removes the need (and assumption) that the portal should be managing both ClusterRole and ClusterRoleBinding. Now, only the ClusterRoleBinding is required to be edited.
Also fixes the redirect after saving the members -> goes back to BE details instead of Zones.
Checklist
bug
,enhancement
,documentation
,change
,breaking
,as they show up in the changelog