Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation #1

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Initial implementation #1

merged 1 commit into from
Oct 30, 2024

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Oct 23, 2024

Adds a deployment for the cloudscale provider. The cloudscale provider then manages the machines and a separate deployment for the missing OpenShift components like the MachineSet controller.

The service account is bound to the cluster-admin role since it needs all permissions of the target MachineSet/* controllers and all permissions a provider requires.

The PR contains an alert that fires if managing the MachineSet controller deployment fails.

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@bastjan bastjan force-pushed the initial-implementation branch from 822d55d to 39cf5a2 Compare October 24, 2024 15:49
@bastjan bastjan requested a review from a team October 24, 2024 16:09
@bastjan bastjan marked this pull request as ready for review October 24, 2024 16:13
@bastjan bastjan force-pushed the initial-implementation branch from 39cf5a2 to ee760ff Compare October 25, 2024 14:16
Copy link

@HappyTetrahedron HappyTetrahedron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward as far as components go.

@bastjan bastjan added enhancement New feature or request bump:minor labels Oct 30, 2024
Copy link

github-actions bot commented Oct 30, 2024

🚀 This PR has been released as v0.1.0

Triggering workflows Release

🛠️ Auto tagging enabled with label bump:minor

@bastjan bastjan merged commit 14ac47a into master Oct 30, 2024
9 checks passed
@bastjan bastjan deleted the initial-implementation branch October 30, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump:minor enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants