Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support deploying only LogForwarding #138

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Support deploying only LogForwarding #138

merged 2 commits into from
Jul 8, 2024

Conversation

DebakelOrakel
Copy link
Contributor

@DebakelOrakel DebakelOrakel commented Jul 5, 2024 •
edited
Loading

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@DebakelOrakel DebakelOrakel added the enhancement New feature or request label Jul 5, 2024
@DebakelOrakel DebakelOrakel requested a review from a team as a code owner July 5, 2024 06:20
bastjan
bastjan reviewed Jul 5, 2024
View reviewed changes
Copy link
Contributor

@bastjan bastjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks sound. I'm however pretty sure cruft updates and other code changes must not be in the same commit. Otherwise cruft gets majorly confused the next time.

@bastjan bastjan self-requested a review July 5, 2024 07:13
@DebakelOrakel DebakelOrakel force-pushed the feat/support-forwarding-only branch from 6c0a8c8 to 0567c2d Compare July 5, 2024 07:16
Update from template
95c0fb7 
Template version: main (689cbcc)
@DebakelOrakel DebakelOrakel reopened this Jul 5, 2024
@DebakelOrakel DebakelOrakel force-pushed the feat/support-forwarding-only branch 2 times, most recently from 454c5f5 to 2248318 Compare July 5, 2024 08:47
@DebakelOrakel DebakelOrakel added the bump:minor Autorelease Minor version label Jul 5, 2024
@DebakelOrakel DebakelOrakel force-pushed the feat/support-forwarding-only branch from 2248318 to dccf32d Compare July 5, 2024 12:49
@DebakelOrakel DebakelOrakel removed the bump:minor Autorelease Minor version label Jul 8, 2024
@appuio appuio deleted a comment from github-actions bot Jul 8, 2024
@DebakelOrakel DebakelOrakel merged commit d665496 into master Jul 8, 2024
17 checks passed
@DebakelOrakel DebakelOrakel deleted the feat/support-forwarding-only branch July 8, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastjan bastjan bastjan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DebakelOrakel @bastjan