Refactor ClusterLogging and ClusterLogForwarder generation code #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DebakelOrakel
force-pushed
the
refactor/config-manifests
branch
9 times, most recently
from
0e65796 to
a09514b
Compare
DebakelOrakel
force-pushed
the
refactor/config-manifests
branch
2 times, most recently
from
881b592 to
5a7dee1
Compare
simu
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
LGTM overall.
I'd heavily recommend testing this by locally compiling some cluster catalogs where we customize the logging stack with this feature branch checked out for the logging component to ensure that this is a non-breaking 0-diff change for our real configs, if you haven't done so already.
tests/golden/defaults/openshift4-logging/openshift4-logging/30_cluster_logging.yaml
Show resolved
Hide resolved
DebakelOrakel
force-pushed
the
refactor/config-manifests
branch
from
5a7dee1 to
3f25d5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.