Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor configuration of ClusterLogForwarder #149

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

DebakelOrakel
Copy link
Contributor

@DebakelOrakel DebakelOrakel commented Aug 10, 2024

With this commit configuring the ClusterLogForwarder resource will be done with a new parameter openshift4_logging.clusterLogForwarder, which will follow the upstream convention / spec.

The old parameter openshift4_logging.clusterLogForwarding is deprecated, but existing legacy config will be respected.

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@DebakelOrakel DebakelOrakel requested a review from a team as a code owner August 10, 2024 10:15
Copy link
Contributor

github-actions bot commented Aug 10, 2024

No bump labels present

🛠️ Auto tagging disabled

@DebakelOrakel DebakelOrakel marked this pull request as draft August 10, 2024 10:16
Template version: main (8840f87)
@DebakelOrakel DebakelOrakel force-pushed the refactor/config-clusterlogforwarder branch 5 times, most recently from 294d837 to 9b3bb90 Compare August 10, 2024 11:41
@DebakelOrakel DebakelOrakel force-pushed the refactor/config-clusterlogforwarder branch 4 times, most recently from 16b1425 to c28fd52 Compare August 10, 2024 12:44
@DebakelOrakel DebakelOrakel marked this pull request as ready for review August 10, 2024 12:44
@DebakelOrakel DebakelOrakel force-pushed the refactor/config-clusterlogforwarder branch 3 times, most recently from 584ee7f to a4e56a7 Compare August 11, 2024 07:36
With this commit configuring the ClusterLogForwarder resource will be done with
a new parameter `openshift4_logging.clusterLogForwarder`, which will follow the
upstream convention / spec.

The old parameter `openshift4_logging.clusterLogForwarding` is deprecated, but
existing legacy config will be respected.
@DebakelOrakel DebakelOrakel force-pushed the refactor/config-clusterlogforwarder branch from a4e56a7 to 742ce51 Compare August 11, 2024 07:39
tests/forwardingonly.yml Show resolved Hide resolved
@DebakelOrakel DebakelOrakel merged commit 55866f5 into master Aug 13, 2024
18 checks passed
@DebakelOrakel DebakelOrakel deleted the refactor/config-clusterlogforwarder branch August 13, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add wildcard namespace selector for clusterLogForwarding.namespace_groups
2 participants