Fix initial sync for ClusterLogForwarder resources
#157
+20
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
Add `SkipDryRunOnMissingResource=true` to `ClusterLogForwarder` so that the initial sync of the openshift4-logging ArgoCD app can succeed.
simu
force-pushed
the
fix/forwarder-skip-dry-run-on-missing-resource
branch
from
867b9dc to
022fb85
Compare
DebakelOrakel
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
SkipDryRunOnMissingResource=truetoClusterLogForwarderso that the initial sync of the openshift4-logging ArgoCD app can succeed.Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.