-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OpenShift Logging 6.x #158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template version: main (ff9d5a8)
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
DebakelOrakel
force-pushed
the
breaking/support-logging-6.x
branch
4 times, most recently
from
December 23, 2024 09:28
e0e3320
to
70df656
Compare
DebakelOrakel
force-pushed
the
breaking/support-logging-6.x
branch
from
December 23, 2024 09:58
70df656
to
8dc084e
Compare
DebakelOrakel
force-pushed
the
breaking/support-logging-6.x
branch
3 times, most recently
from
December 23, 2024 13:35
107bd7f
to
21794f4
Compare
DebakelOrakel
force-pushed
the
breaking/support-logging-6.x
branch
from
December 23, 2024 13:37
21794f4
to
d060a41
Compare
simu
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, see inline comments for some smaller things that I noticed.
Co-authored-by: Simon Gerber <[email protected]>
DebakelOrakel
force-pushed
the
breaking/support-logging-6.x
branch
from
December 24, 2024 08:15
f7752e3
to
1af6f4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter
clusterLogForwarding
is deprecated.Backward compatibility for
clusterLogForwarding
has been removed.The parameter
clusterLogging
is deprecated and has been removed.Migrate collector configuration to
clusterLogForwarder.collector
.The parameter
namespaceLogForwarderEnabled
is deprecated and has been removed.Multi LogForwarder is enabled by default, see How-To for migration if it was not enabled.
The parameter
namespaceLogForwarder
is deprecated and has been removed.If you are using Multi LogForwarder with ProjectSyn, migrate them to
adhoc-configuration
.The parameters
ignore_alerts
andpatch_alerts
are deprecated.The component is backwards compatible, but moving the parameters to
alerts.ignore
andalerts.patch
is highly encouraged.Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog.