Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenShift Logging 6.x #158

Merged
merged 7 commits into from
Dec 24, 2024
Merged

Conversation

DebakelOrakel
Copy link
Contributor

@DebakelOrakel DebakelOrakel commented Dec 21, 2024

The parameter clusterLogForwarding is deprecated.
Backward compatibility for clusterLogForwarding has been removed.

The parameter clusterLogging is deprecated and has been removed.
Migrate collector configuration to clusterLogForwarder.collector.

The parameter namespaceLogForwarderEnabled is deprecated and has been removed.
Multi LogForwarder is enabled by default, see How-To for migration if it was not enabled.

The parameter namespaceLogForwarder is deprecated and has been removed.
If you are using Multi LogForwarder with ProjectSyn, migrate them to adhoc-configuration.

The parameters ignore_alerts and patch_alerts are deprecated.
The component is backwards compatible, but moving the parameters to alerts.ignore and alerts.patch is highly encouraged.

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

DebakelOrakel and others added 2 commits December 21, 2024 15:14
@DebakelOrakel DebakelOrakel requested a review from a team as a code owner December 21, 2024 14:22
Copy link
Contributor

github-actions bot commented Dec 21, 2024

🚀 This PR has been released as v5.0.0

Triggering workflows Release

🛠️ Auto tagging enabled with label bump:major

@DebakelOrakel DebakelOrakel force-pushed the breaking/support-logging-6.x branch 4 times, most recently from e0e3320 to 70df656 Compare December 23, 2024 09:28
@DebakelOrakel DebakelOrakel force-pushed the breaking/support-logging-6.x branch from 70df656 to 8dc084e Compare December 23, 2024 09:58
@DebakelOrakel DebakelOrakel force-pushed the breaking/support-logging-6.x branch 3 times, most recently from 107bd7f to 21794f4 Compare December 23, 2024 13:35
@DebakelOrakel DebakelOrakel force-pushed the breaking/support-logging-6.x branch from 21794f4 to d060a41 Compare December 23, 2024 13:37
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, see inline comments for some smaller things that I noticed.

component/alertrules.libsonnet Outdated Show resolved Hide resolved
component/alertrules.libsonnet Outdated Show resolved Hide resolved
component/alertrules.libsonnet Show resolved Hide resolved
@DebakelOrakel DebakelOrakel force-pushed the breaking/support-logging-6.x branch from f7752e3 to 1af6f4f Compare December 24, 2024 08:15
@DebakelOrakel DebakelOrakel merged commit 06bb2c5 into master Dec 24, 2024
13 checks passed
@DebakelOrakel DebakelOrakel deleted the breaking/support-logging-6.x branch December 24, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking Changes bump:major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants