Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deploying arbitrary cronjobs #196

Merged
merged 9 commits into from
Apr 5, 2024
Merged

Conversation

haasad
Copy link
Member

@haasad haasad commented Apr 5, 2024

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@haasad haasad added the enhancement New feature or request label Apr 5, 2024
@haasad haasad requested a review from a team as a code owner April 5, 2024 09:00
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks inline. LGTM overall. jsonnet linting is probably unhappy about the double-quotes.

component/cronjobs.libsonnet Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/references/parameters.adoc Outdated Show resolved Hide resolved
@haasad haasad merged commit 06d57db into master Apr 5, 2024
26 checks passed
@haasad haasad deleted the feat/cronjobs branch April 5, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants