Add support for deploying an additional node-exporter DaemonSet #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
feat/custom-node-exporter
branch
6 times, most recently
from
a265d50 to
638155b
Compare
We reuse the cluster-monitoring-operator node-exporter Jsonnet to generate the DaemonSet and associated resources, and patch the output to remove resources that we don't need.
We can safely enable automerge for `oc` and `node-exporter` since we already know that we won't break minor releases of `appuio/oc` and node-exporter is used widely enough. Additionally, we can safely enable automerge for `kube-rbac-proxy` given that the recent updates have adhered to SemVer even though the project is still at v0.x. Rendered from template version: main (26ee71e)
simu
force-pushed
the
feat/custom-node-exporter
branch
from
638155b to
6f9e209
Compare
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
simu
changed the title
simu
changed the title
DebakelOrakel
approved these changes
Jun 19, 2024
bastjan
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We reuse the cluster-monitoring-operator node-exporter Jsonnet to generate the DaemonSet and associated resources, and patch the output to adjust the node-exporter to not conflict with the default node-exporter and to remove resources that we don't need.
Additionally, we enable automerge for the 3rd party container images used by the component.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.