Apply suggestions from code review

Co-authored-by: Simon Gerber <[email protected]>
appuio · Jun 19, 2024 · 88447b3 · 88447b3
1 parent c806751
commit 88447b3
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/class/defaults.yml b/class/defaults.yml
@@ -43,7 +43,7 @@ parameters:
                 tags: []
                 userDataSecret:
                   name: worker-user-data
-    cpDefaultSpecs:
+    controlPlaneDefaultSpecs:
       vsphere: {}
       aws: {}
       azure: {}

diff --git a/component/machine-sets.jsonnet b/component/machine-sets.jsonnet
@@ -58,7 +58,7 @@ local machineSetSpecs = function(name, set, role)
 
 local cpMachineSetSpecs = function(set)
   kube._Object('machine.openshift.io/v1', 'ControlPlaneMachineSet', 'cluster') {
-    spec+: params.cpDefaultSpecs[inv.parameters.facts.cloud],
+    spec+: params.controlPlaneDefaultSpecs[inv.parameters.facts.cloud],
   } + {
     metadata+: {
       annotations+: std.get(set, 'annotations', {}),

diff --git a/docs/modules/ROOT/pages/references/parameters.adoc b/docs/modules/ROOT/pages/references/parameters.adoc
@@ -39,7 +39,7 @@ A dictionary holding the default values applied to each `machinesets.machine.ope
 The top level keys are the names of cloud providers as reported by the cluster fact `${facts:cloud}`.
 The values can be everything that's accepted in the `spec` field of a `machinesets.machine.openshift.io` object.
 
-== `cpDefaultSpecs`
+== `controlPlaneDefaultSpecs`
 
 [horizontal]
 type:: dictionary

diff --git a/tests/golden/gcp/openshift4-nodes/openshift4-nodes/machineset-master.yaml b/tests/golden/gcp/openshift4-nodes/openshift4-nodes/machineset-master.yaml
@@ -57,5 +57,5 @@ spec:
             tags:
               - infra-id-master
             userDataSecret:
-              name: worker-user-data
+              name: master-user-data
             zone: europe-west6-a