Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic ability to configure MachineSets #1

Merged
merged 11 commits into from
Jul 2, 2020
Merged

Add basic ability to configure MachineSets #1

merged 11 commits into from
Jul 2, 2020

Conversation

corvus-ch
Copy link
Contributor

@corvus-ch corvus-ch commented Jun 29, 2020 •
edited
Loading

Initial implementation.

  • Adds ability for managing MachineSets in a simple streamline fashion by providing some syntactic sugar.
  • Also allows to control each aspect of the resulting MachineSet.
  • Does not take care of auto scaling. See Allow to configure auto scaling #5.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation.
  • Update the ./CHANGELOG.md.
  • Link this PR to related issues.

@corvus-ch corvus-ch self-assigned this Jun 29, 2020
@corvus-ch corvus-ch force-pushed the initial branch 2 times, most recently from 0d3f0bb to ff5e323 Compare June 30, 2020 14:33
@corvus-ch corvus-ch changed the title Initial Add basic ability to configure MachineSets Jul 2, 2020
@corvus-ch corvus-ch marked this pull request as ready for review July 2, 2020 09:51
@corvus-ch corvus-ch requested review from tobru and srueg July 2, 2020 09:51
srueg
srueg suggested changes Jul 2, 2020
View reviewed changes
component/main.jsonnet Show resolved Hide resolved
docs/modules/ROOT/pages/references/parameters.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/references/parameters.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/references/parameters.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/references/parameters.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/references/parameters.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/references/parameters.adoc Outdated Show resolved Hide resolved
@corvus-ch corvus-ch requested a review from srueg July 2, 2020 14:56
@corvus-ch corvus-ch merged commit 451bc49 into master Jul 2, 2020
@corvus-ch corvus-ch deleted the initial branch July 2, 2020 15:08
@ccremer ccremer added the enhancement New feature or request label Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srueg srueg srueg approved these changes

@tobru tobru tobru approved these changes

Assignees

@corvus-ch corvus-ch

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corvus-ch @srueg @tobru @ccremer