Support creating ControlPlaneMachineSet #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If using a NodeGroup named `master` a ControlPlaneMachineSet will be created instead of a normal MachineSet.
DebakelOrakel
force-pushed
the
feat/support-cpmachineset
branch
from
ba70a07 to
f207313
Compare
simu
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
LGTM overall, some code nitpicks inline.
However, if you haven't done so yet, I'd like to have a sanity check by configuring the feature for one of our existing clusters and verifying that this generates a ControlPlaneMachineSet that's identical to the deployed one.
Co-authored-by: Simon Gerber <[email protected]>
DebakelOrakel
force-pushed
the
feat/support-cpmachineset
branch
from
b2ea553 to
1656ef9
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using a NodeGroup named
mastera ControlPlaneMachineSet will be created instead of a normal MachineSet.Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.