Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only deploy storage canary manifests if storage canary SLO is enabled #79

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

haasad
Copy link
Member

@haasad haasad commented Aug 9, 2024

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@haasad haasad added enhancement New feature or request bump:minor labels Aug 9, 2024
@haasad haasad requested a review from a team as a code owner August 9, 2024 13:15
Copy link

github-actions bot commented Aug 9, 2024

🚀 This PR has been released as v1.10.1

Triggering workflows Release

🛠️ Auto tagging enabled with label bump:patch

@haasad haasad force-pushed the feat/option-disable-storage-canary branch from 199d518 to 740981a Compare August 9, 2024 13:50
@haasad haasad added bug Something isn't working bump:patch and removed enhancement New feature or request bump:minor labels Aug 9, 2024
@haasad haasad force-pushed the feat/option-disable-storage-canary branch from 740981a to 81c4a78 Compare August 9, 2024 13:51
@haasad haasad changed the title Add option to fully disable the storage canary. Only deploy storage canary manifests if storage canary SLO is enabled Aug 9, 2024
@haasad haasad merged commit 48d4953 into master Aug 9, 2024
9 checks passed
@haasad haasad deleted the feat/option-disable-storage-canary branch August 9, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bump:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants