Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement token request and first store in secret #2

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Implement token request and first store in secret #2

merged 1 commit into from
Nov 2, 2023

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Oct 31, 2023 •
edited
Loading

Too much code - as always with the initial implementation. Sorry.

  • Adds a CRD+Controller to create emergency account tokens
  • The controller:
    • Reconciles a SA with the same name as the CRD
    • Requests tokens if not enough verified tokens exists
    • Stores those tokens
    • Verifies those tokens, using TokenReview

The storage implementation is generic through StoreToken, if the implementation supports RetrieveToken the token is periodically checked against Kubernetes.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.

@bastjan bastjan force-pushed the initial-implementation branch from eb24fee to 15d4e09 Compare November 1, 2023 17:05
@bastjan bastjan added the enhancement New feature or request label Nov 2, 2023
@bastjan bastjan marked this pull request as ready for review November 2, 2023 13:28
@bastjan bastjan requested a review from a team as a code owner November 2, 2023 13:28
simu
simu approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Some inline comments for probaby outdated comments.

api/v1beta1/emergencyaccount_types.go Outdated Show resolved Hide resolved
api/v1beta1/emergencyaccount_types.go Outdated Show resolved Hide resolved
@bastjan bastjan force-pushed the initial-implementation branch from 15d4e09 to a1c6171 Compare November 2, 2023 14:07
@bastjan bastjan merged commit c2c2705 into master Nov 2, 2023
3 checks passed
@bastjan bastjan deleted the initial-implementation branch November 2, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastjan @simu