Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Simon Gerber <[email protected]>
  • Loading branch information
bastjan and simu authored Oct 26, 2023
1 parent f919291 commit 91cd81c
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

== Problem Statement

Our current log in system, based on LDAP has security issues.
It doesn't allow for 2FA, and we enter our password in a lot of different masks, that could in theory be compromised.
Our current log in system, which is based on LDAP, has security issues.
It doesn't allow for 2FA, and we enter our password in a lot of different masks that could be compromised.

We use Keycloak as the SSO solution for internal services and want to use it for customer clusters as well.
Keycloak uses `Clients` to represent applications that can be logged into.
Expand Down Expand Up @@ -99,7 +99,7 @@ This config map is managed by `component-steward` and new facts can be added thr
parameters:
steward:
additionalFacts:
vshnLdapServiceId: "{vshnLdap:serviceId}"
vshnLdapServiceId: "${vshnLdap:serviceId}"
----

=== The controller maps LDAP groups to local client roles
Expand Down

0 comments on commit 91cd81c

Please sign in to comment.