-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update install instructions for 4.14 on Exoscale #320
Conversation
VSHNeer login works without the ldap stuff. |
2d7e3c0
to
6a03986
Compare
@@ -29,9 +29,6 @@ yq eval -i ".parameters.openshift.clusterID = \"$(jq -r .clusterID "${INSTALLER_ | |||
|
|||
yq eval -i ".parameters.openshift.ssh_key = \"$(cat ${SSH_PUBLIC_KEY})\"" \ | |||
${CLUSTER_ID}.yml | |||
|
|||
yq eval -i ".parameters.vshnLdap.serviceId = \"${LDAP_ID}\"" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simu introduced a new parameter here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on how we move forward, we may not need to set the new parameter for each new cluster.
@bastjan, what happens if we configure a client-role for a Keycloak group that doesn't exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove all ldap related changes from this PR anyways for a nicer changelog. Let's do them in a separate PR.
@@ -14,25 +14,3 @@ For customer clusters, set the following cluster facts in Lieutenant: | |||
* `service_level`: Name of the service level agreement for this cluster, such as `guaranteed-availability` | |||
* `sales_order`: Name of the sales order to which the cluster is billed, such as `S10000` | |||
* `release_channel`: Name of the syn component release channel to use, such as `stable` | |||
|
|||
=== Set up LDAP service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want to replace this with a "Set up Keycloak service group" for now (until we get around to ensuring that such service groups are created automatically for each cluster.
I would write the new section so that we always use the cluster's Project Syn ID as the service group ID and the cluster's Project Syn display name as the service group name. That way we can configure the service group name as ${cluster:name}
instead of having to manually configure it during cluster setup.
@@ -29,9 +29,6 @@ yq eval -i ".parameters.openshift.clusterID = \"$(jq -r .clusterID "${INSTALLER_ | |||
|
|||
yq eval -i ".parameters.openshift.ssh_key = \"$(cat ${SSH_PUBLIC_KEY})\"" \ | |||
${CLUSTER_ID}.yml | |||
|
|||
yq eval -i ".parameters.vshnLdap.serviceId = \"${LDAP_ID}\"" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on how we move forward, we may not need to set the new parameter for each new cluster.
@bastjan, what happens if we configure a client-role for a Keycloak group that doesn't exist?
6a03986
to
1515293
Compare
Reverted the LDAP changes |
No description provided.