Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use amtool in the alertmanager pod instead of silencing job #322

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

haasad
Copy link
Member

@haasad haasad commented Apr 9, 2024

Reduces the number of manual steps needed (no cleanup of jobs etc.) and reduces the wall of code in the how-to

@haasad haasad requested a review from simu April 9, 2024 22:37
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might make sense to update the partials to always use amtool instead of just dropping the partial here. That way, we'd improve all the how-tos that create silences instead of just one of them.

@simu simu self-requested a review April 10, 2024 07:28
@haasad
Copy link
Member Author

haasad commented Apr 15, 2024

I created partials for creating and expiring silences with amtool. I don't have the capacity at the moment to migrate all existing silence jobs to the new method. But like this we can reuse the new method when needed.

@haasad haasad merged commit 93affe1 into master Apr 15, 2024
1 check passed
@haasad haasad deleted the simplify-silencing branch April 15, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants