-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update generic node removal documentation to schedule a drain when removing worker nodes #324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current changes generate a lot of unnecessary content for the storage node how-tos. We never need to schedule a storage node drain for the next maintenance, so there's no point in including all that text in those how-tos.
* First, we identify the correct node to remove and drain it. | ||
* Then, we remove it from Kubernetes. | ||
* Finally, we remove the associated VMs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the commas here are correct in English, but I always trip over comma rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally you don't use commas after "first", "second" etc. but in the context of a list of things you use them anyway. The exception to the rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though I guess since this is a bullet list you could consider each bullet point a standalone sentence and skip the comma... Huh. Guess it's a special case.
(The comma would be needed if all these sentences came one-after-the-other in the same paragraph)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though I guess since this is a bullet list you could consider each bullet point a standalone sentence
I guess that's what confused me when reviewing. I don't have hard feelings either way, but I'm still mentally stumbling over the commas in the bullet list.
9495151
to
070ae40
Compare
+ | ||
ifeval::["{cloud_provider}" == "cloudscale"] | ||
ifeval::["{delete-node-type}" == "storage"] | ||
[TIP] | ||
==== | ||
On cloudscale.ch, we configure Rook Ceph to setup the OSDs in "portable" mode. | ||
This configuration enables OSDs to be scheduled on any storage node. | ||
|
||
With this configuration, we don't have to migrate OSDs hosted on the old node(s) manually. | ||
Instead, draining a node will cause any OSDs hosted on that node to be rescheduled on other storage nodes. | ||
==== | ||
endif::[] | ||
endif::[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tip isn't needed for the scheduling case
+ | |
ifeval::["{cloud_provider}" == "cloudscale"] | |
ifeval::["{delete-node-type}" == "storage"] | |
[TIP] | |
==== | |
On cloudscale.ch, we configure Rook Ceph to setup the OSDs in "portable" mode. | |
This configuration enables OSDs to be scheduled on any storage node. | |
With this configuration, we don't have to migrate OSDs hosted on the old node(s) manually. | |
Instead, draining a node will cause any OSDs hosted on that node to be rescheduled on other storage nodes. | |
==== | |
endif::[] | |
endif::[] |
* First, we identify the correct node to remove and drain it. | ||
* Then, we remove it from Kubernetes. | ||
* Finally, we remove the associated VMs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though I guess since this is a bullet list you could consider each bullet point a standalone sentence
I guess that's what confused me when reviewing. I don't have hard feelings either way, but I'm still mentally stumbling over the commas in the bullet list.
… on a prod cluster
dd4d01e
to
0784d12
Compare
No description provided.