Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decision: OCP minor version tracking #327

Merged
merged 5 commits into from
May 13, 2024
Merged

Decision: OCP minor version tracking #327

merged 5 commits into from
May 13, 2024

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented May 13, 2024

No description provided.

@bastjan bastjan force-pushed the decision-ocp-minor-version-tracking branch from c9f7e16 to 349e2e0 Compare May 13, 2024 11:44
@bastjan bastjan force-pushed the decision-ocp-minor-version-tracking branch from 349e2e0 to df69db9 Compare May 13, 2024 11:47
@bastjan bastjan requested a review from a team May 13, 2024 11:47
haasad
haasad approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@haasad haasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you decide against including the "admin acknowledgement" process in this decision? IMO it would make sense to have it mentioned here, i.e. that setting the new channel implicitly triggers the admin ack.

docs/modules/ROOT/pages/explanations/decisions/ocp-minor-version-tracking.adoc Outdated Show resolved Hide resolved
@bastjan
Copy link
Contributor Author

bastjan commented May 13, 2024

Did you decide against including the "admin acknowledgement" process in this decision? IMO it would make sense to have it mentioned here, i.e. that setting the new channel implicitly triggers the admin ack.

Good call, needs to be included for completeness.

simu
simu approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some spelling wording suggestions inline.

docs/modules/ROOT/pages/explanations/decisions/ocp-minor-version-tracking.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/explanations/decisions/ocp-minor-version-tracking.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/explanations/decisions/ocp-minor-version-tracking.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/explanations/decisions/ocp-minor-version-tracking.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/explanations/decisions/ocp-minor-version-tracking.adoc Show resolved Hide resolved
@bastjan bastjan merged commit a884a3a into master May 13, 2024
1 check passed
@bastjan bastjan deleted the decision-ocp-minor-version-tracking branch May 13, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haasad haasad haasad approved these changes

@simu simu simu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastjan @simu @haasad