Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add general guideline for control plane node scaling #344

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

DebakelOrakel
Copy link
Contributor

Relates: OCP-840

@DebakelOrakel DebakelOrakel added the documentation Improvements or additions to documentation label Jul 19, 2024
@DebakelOrakel DebakelOrakel force-pushed the control-plane-scaling-guide branch 4 times, most recently from 77380c2 to 95115f0 Compare July 26, 2024 06:52
@DebakelOrakel DebakelOrakel force-pushed the control-plane-scaling-guide branch from 95115f0 to 1e5305e Compare July 26, 2024 07:27
@DebakelOrakel DebakelOrakel requested a review from a team July 26, 2024 08:27
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Some suggestions inline.

docs/modules/ROOT/pages/references/cp_node_scaling.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/references/cp_node_scaling.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/references/cp_node_scaling.adoc Outdated Show resolved Hide resolved
Comment on lines +28 to +30
| 4 CPU

24Gi Memory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This size doesn't really make sense on any provider except vSphere where we can do whatever we want. Neither cloudscale nor Exoscale have a 4 CPU / 24Gi VM size.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vSphere has 😁

docs/modules/ROOT/pages/references/cp_node_scaling.adoc Outdated Show resolved Hide resolved
@simu simu requested a review from bastjan July 26, 2024 08:32
Copy link
Contributor

@bastjan bastjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the wording improvements from @simu 😊

@DebakelOrakel DebakelOrakel merged commit abbc507 into master Jul 26, 2024
1 check passed
@DebakelOrakel DebakelOrakel deleted the control-plane-scaling-guide branch July 26, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants