-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add general guideline for control plane node scaling #344
Conversation
77380c2
to
95115f0
Compare
Relates: OCP-840
95115f0
to
1e5305e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Some suggestions inline.
| 4 CPU | ||
|
||
24Gi Memory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This size doesn't really make sense on any provider except vSphere where we can do whatever we want. Neither cloudscale nor Exoscale have a 4 CPU / 24Gi VM size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vSphere has 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the wording improvements from @simu 😊
Co-authored-by: Simon Gerber <[email protected]>
Relates: OCP-840