-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cloudscale install documentation to enable machine-api provider #365
Conversation
b29884f
to
3d74356
Compare
Co-authored-by: Simon Gerber <[email protected]>
Co-authored-by: Simon Gerber <[email protected]>
ssh "${fqdn}" sudo puppetctl run | ||
done | ||
---- | ||
git clone [email protected]:appuio/appuio_hieradata.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The terraform checkout of this repo uses the project bot user via https, and trying to do anything in it asks for the bot's password, which is annoying to script for.
I may be missing something. But I found it easier to just re-clone with ssh...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could maybe do something like
git remote add origin-git [email protected]:appuio/appuio-hieradata.git
in the Terraform checkout and then
git push origin-git master
but that's not easier than just cloning the repo again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah... plus, in my local directory the terraform-managed checkout wasn't in a clean state. Whether that was a result of me doing things wrong or a normal possibility, I'm not sure. But a fresh clone certainly never has issues with unclean git trees...
ssh "${fqdn}" sudo puppetctl run | ||
done | ||
---- | ||
git clone [email protected]:appuio/appuio_hieradata.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could maybe do something like
git remote add origin-git [email protected]:appuio/appuio-hieradata.git
in the Terraform checkout and then
git push origin-git master
but that's not easier than just cloning the repo again.
I imagine at some point we'll update the openshift4-terraform defaults for cloudscale to have infra and worker counts of 0. For now, though, I assume that this is not the case and have the install instructions explicitly leave an override in.
Once we're fully migrated, we will probably also have the machine-api-provider-cloudscale component enabled and configured by default, and that step will be superfluous as well. (There's a small bootstrapping snag here: the component config tries to access the ignition CA from the openshift4-terraform config. On the very first catalog compile, that isn't there. But I'm sure we can work around that once we get that far.)