Update Cilium migration how-to to always use api-int
#369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
changed the title
api-int.api-int
We can't use the public `api` record since Cilium simply patches the clientset generated by `InClusterConfig()` [1] with the provided API host name, cf. `createConfig()` [2]. Notably, the clientset still uses the K8s-managed in-cluster CA bundle which isn't suitable for validating public certificates. If we actually want to use `api` record, we'd have to somehow configure Cilium to use a custom kubeconfig (which I'm not sure is possible when running Cilium in a cluster). [1]: https://pkg.go.dev/k8s.io/client-go/rest#InClusterConfig [2]: https://github.com/cilium/cilium/blob/bb81b095cb64053887e3cb087b53518c162beec6/pkg/k8s/client/cell.go#L348-L352
simu
force-pushed
the
fix/cilium-migration-api-int
branch
from
2f70aea to
e364a72
Compare
haasad
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't use the public
apirecord since Cilium simply patches the clientset generated byInClusterConfig()with the provided API host name, cf. https://github.com/cilium/cilium/blob/bb81b095cb64053887e3cb087b53518c162beec6/pkg/k8s/client/cell.go#L348-L352. Notably, the clientset still uses the K8s-managed in-cluster CA bundle which isn't suitable for validating public certificates.If we actually want to use
apirecord, we'd have to somehow configure Cilium to use a custom kubeconfig (which I'm not sure is possible when running Cilium in a cluster).