Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decision for autoscaling with restricted downscaling #370

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

simu
Copy link
Member

@simu simu commented Dec 6, 2024

No description provided.

@simu simu requested a review from a team December 6, 2024 12:20
@simu simu force-pushed the decision/downscaling-windows branch from f481f9d to ea42108 Compare December 6, 2024 16:58
Copy link
Member

@haasad haasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision looks fine!

Two thoughts that came up while reviewing this:

  • How big is the chance/risk of two nodes being drained simultaneously? One by the maintenance and one for downscaling. This could create problems for deployments without PDBs that rely on the fact the we usually never drain two nodes at the same time.
  • Is there a risk that the autoscaler will always add a node during the maintenance (because resources are tight during node rebooting) which will then not be downscaled anymore (because the maintenance window is already over) and lay around until the next maintenance?

@simu
Copy link
Member Author

simu commented Dec 9, 2024

How big is the chance/risk of two nodes being drained simultaneously? One by the maintenance and one for downscaling. This could create problems for deployments without PDBs that rely on the fact the we usually never drain two nodes at the same time.

There's a chance for this to happen, but I assume that if we enable downscaling at the start of the maintenance, any nodes that are getting scaled down will be gone by the time the maintenance updates the nodes.

Is there a risk that the autoscaler will always add a node during the maintenance (because resources are tight during node rebooting) which will then not be downscaled anymore (because the maintenance window is already over) and lay around until the next maintenance?

There is probably a risk for that, we could mitigate this by implementing a delay in the downscaling disable hook to allow the autoscaler to scale down such a node.

@simu simu force-pushed the decision/downscaling-windows branch from ea42108 to 509bac2 Compare December 9, 2024 09:15
@simu simu merged commit 2887809 into master Dec 9, 2024
1 check passed
@simu simu deleted the decision/downscaling-windows branch December 9, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants