Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private Endpoints Version 0.2.9 #42

Merged
merged 5 commits into from
Aug 30, 2024
Merged

Private Endpoints Version 0.2.9 #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b7847b
chore(deps): using the inbuilt code rather than upstream module
gambol99 Aug 30, 2024
2b8247e
fix: trying to fix the propagation issue
gambol99 Aug 30, 2024
f7f29bc
fix: adding back the propagation for now
gambol99 Aug 30, 2024
8f5934f
chore(deps): bumping to a fixed version
gambol99 Aug 30, 2024
566daff
docs: updating to reflect the changes
gambol99 Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .tflint.hcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ rule "terraform_documented_variables" {
}

rule "terraform_module_pinned_source" {
enabled = true
enabled = false
}

rule "terraform_standard_module_structure" {
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ The `terraform-docs` utility is used to generate this README. Follow the below s
| <a name="module_dns"></a> [dns](#module\_dns) | appvia/dns/aws | 1.2.1 |
| <a name="module_dns_vpc"></a> [dns\_vpc](#module\_dns\_vpc) | appvia/network/aws | 0.3.1 |
| <a name="module_egress_vpc"></a> [egress\_vpc](#module\_egress\_vpc) | appvia/network/aws | 0.3.1 |
| <a name="module_endpoints"></a> [endpoints](#module\_endpoints) | appvia/private-endpoints/aws | 0.2.8 |
| <a name="module_endpoints"></a> [endpoints](#module\_endpoints) | appvia/private-endpoints/aws | 0.2.9 |
| <a name="module_endpoints_vpc"></a> [endpoints\_vpc](#module\_endpoints\_vpc) | appvia/network/aws | 0.3.1 |
| <a name="module_ingress_vpc"></a> [ingress\_vpc](#module\_ingress\_vpc) | appvia/network/aws | 0.3.1 |
| <a name="module_inspection_vpc"></a> [inspection\_vpc](#module\_inspection\_vpc) | appvia/network/aws | 0.3.1 |
Expand Down
2 changes: 1 addition & 1 deletion endpoints.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ module "endpoints_vpc" {
module "endpoints" {
count = local.enable_endpoints ? 1 : 0
source = "appvia/private-endpoints/aws"
version = "0.2.8"
version = "0.2.9"

name = var.services.endpoints.network.name
endpoints = var.services.endpoints.services
Expand Down
4 changes: 1 addition & 3 deletions locals.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,9 @@ locals {

## The transit gateway attaccment id for the endpoints vpc
endpoints_vpc_attachment_id = local.enable_endpoints ? module.endpoints_vpc[0].transit_gateway_attachment_id : null
## The workloads routing table for the trusted configuration
#trusted_workloads_routing_table_id = local.enable_trusted ? module.tgw.ec2_transit_gateway_association_default_route_table_id : null

## Should we enable default propation on the vpc
enable_default_route_table_propagation = local.enable_trusted ? false : true
enable_default_route_table_propagation = true
## Should we enable default association on the vpc
enable_default_route_table_association = local.enable_trusted ? false : true
}