Start building PRO flow #1601
Merged
Start building PRO flow #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o button on the site
ItzNotABug
reviewed
Jan 8, 2025
Comment on lines
+7
to
+11
| if (paramType === 'createPro') { | ||
| shouldRegister | ||
| ? goto(`${base}/register?type=createPro`) | ||
| : goto(`${base}/create-organization?type=createPro`); | ||
| } |
There was a problem hiding this comment.
do we know if we are going to open scale as well, like createScale in the params? I am not yet aware of the Scale GA. If not, lgtm.
There was a problem hiding this comment.
Currently on the website that button is still disabled, and also in the console it's not a visible option. So I thought: we'll cross that bridge when we get there. It is the reason I moved everything into 1 function, so we can easily adjust it when we do need to make that change!
ItzNotABug
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When visiting the console through the "Start building" button on the PRO column of the site pricing, you get redirected to the console.
when not signed in,
when signed in,
Have you read the Contributing Guidelines on issues?
✅