fix: type errors #228
Merged
fix: type errors #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loks0n
commented
Dec 30, 2024
•
loks0n
commented
- Fixes type issue 🐛 Bug Report: type List<dynamic>' is not a subtype of type 'List<String> #224
- Adds realtime heartbeat
lohanidamodar
previously requested changes
Dec 31, 2024
| @@ -115,6 +115,15 @@ class ClientBrowser extends ClientBase with ClientMixin { | |||
| return this; | |||
| } | |||
|
|
|||
| @override | |||
There was a problem hiding this comment.
Both the methods in client_io and client_browser are same they don't need specific access to io or browser features. This method should go into base class instead
christyjacob4
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.