Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: realtime heartbeat for react native #1018

Merged
merged 1 commit into from
Dec 30, 2024
Merged

feat: realtime heartbeat for react native #1018

merged 1 commit into from
Dec 30, 2024

Conversation

loks0n
Copy link
Member

@loks0n loks0n commented Dec 18, 2024

No description provided.

@loks0n loks0n requested a review from lohanidamodar December 20, 2024 10:24
lohanidamodar
lohanidamodar approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This is same as what we have in Web right?

lohanidamodar
lohanidamodar approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This is same as what we have in Web right?

@loks0n
Copy link
Member Author

loks0n commented Dec 23, 2024

Looks good to me. This is same as what we have in Web right?

Yeah it's pretty much identical, except for a small difference with types

@christyjacob4 christyjacob4 merged commit de6ac72 into master Dec 30, 2024
35 checks passed
@christyjacob4 christyjacob4 deleted the feat-realtime-heartbeat-for-react-native branch December 30, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christyjacob4 christyjacob4 christyjacob4 approved these changes

@lohanidamodar lohanidamodar lohanidamodar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loks0n @lohanidamodar @christyjacob4