[move-cm][closures] Refactor: Move type conversions out of Loader into a trait

[wrwg]

Description

[PR 3/n vm closures]

Type conversions from runtime types to MoveTypeLayout and TypeTag currently are associated with the Loader type. However, they are needed for the FunctionValueExtension trait which needs to be constructed in contexts where no loader but only ModuleStorage exists.

This PR moves the conversion functions into a new trait TypeConverter. The trait is then implemented two times, once based on ModuleStorage only and once based on the existing Loader, for downwards compatibility.

How Has This Been Tested?

Refactoring only, existing tests

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Move Compiler
• Other (specify)

[trunk-io]

⏱️ 50m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
rust-move-tests	13m	🟩
rust-cargo-deny	8m	🟩 🟩 ⬜ 🟩 🟩
rust-move-tests	8m	🟥
rust-move-tests	7m	🟥
check-dynamic-deps	6m	🟩 🟩 🟩 🟩 🟩
general-lints	2m	🟩 🟩 🟩 🟩 🟩
rust-move-tests	2m	🟥
semgrep/ci	2m	🟩 🟩 🟩 🟩 🟩
file_change_determinator	56s	🟩 🟩 🟩 🟩 🟩
rust-move-tests	31s	⬜
permission-check	15s	🟩 🟩 🟩 🟩 🟩
permission-check	12s	🟩 🟩 🟩 🟩 🟩
check-branch-prefix	1s	🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[wrwg]

• [move-vm][closures] Interpreter #15680
• [move-vm][closures] Type and Value representation and serialization #15670
• [move-cm][closures] Refactor: Move type conversions out of Loader into a trait #15669 👈 (View in Graphite)
• [move-vm][closures] Refactor: move abilities and closure mask into core types #15668
• [move-vm][closures] Types and opcodes for closures #15667
• [move-vm] Increase bytecode VERSION_MAX to v8 #15777
• [move-prover] Sharding feature + re-animate Prover.toml #15775
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

✅ Forge suite realistic_env_max_load success on 2707a22233557a8ea1c12cc8b0340be109b16793

two traffics test: inner traffic : committed: 14659.29 txn/s, latency: 2701.63 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5573840
two traffics test : committed: 99.99 txn/s, latency: 1407.05 ms, (p50: 1400 ms, p70: 1500, p90: 1500 ms, p99: 1900 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.452, avg: 1.429", "ConsensusProposalToOrdered: max: 0.299, avg: 0.291", "ConsensusOrderedToCommit: max: 0.420, avg: 0.403", "ConsensusProposalToCommit: max: 0.710, avg: 0.694"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.65s no progress at version 18930 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.21s no progress at version 6315376 (avg 0.96s) [limit 16].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on cb5d7c9615b937357dbede9439401be640fb7d17 ==> 2707a22233557a8ea1c12cc8b0340be109b16793

Compatibility test results for cb5d7c9615b937357dbede9439401be640fb7d17 ==> 2707a22233557a8ea1c12cc8b0340be109b16793 (PR)
1. Check liveness of validators at old version: cb5d7c9615b937357dbede9439401be640fb7d17
compatibility::simple-validator-upgrade::liveness-check : committed: 12293.83 txn/s, latency: 2597.29 ms, (p50: 2700 ms, p70: 2900, p90: 3200 ms, p99: 4100 ms), latency samples: 401080
2. Upgrading first Validator to new version: 2707a22233557a8ea1c12cc8b0340be109b16793
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3956.43 txn/s, latency: 7853.74 ms, (p50: 8700 ms, p70: 9300, p90: 9600 ms, p99: 9700 ms), latency samples: 89600
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3997.58 txn/s, latency: 8549.51 ms, (p50: 9500 ms, p70: 9700, p90: 10000 ms, p99: 10100 ms), latency samples: 141120
3. Upgrading rest of first batch to new version: 2707a22233557a8ea1c12cc8b0340be109b16793
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4581.65 txn/s, latency: 6785.29 ms, (p50: 7700 ms, p70: 8000, p90: 8200 ms, p99: 8300 ms), latency samples: 94500
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4504.16 txn/s, latency: 7562.79 ms, (p50: 8500 ms, p70: 8600, p90: 8900 ms, p99: 9000 ms), latency samples: 158760
4. upgrading second batch to new version: 2707a22233557a8ea1c12cc8b0340be109b16793
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 7631.12 txn/s, latency: 3996.33 ms, (p50: 4600 ms, p70: 4800, p90: 5200 ms, p99: 5300 ms), latency samples: 141160
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7592.40 txn/s, latency: 4478.12 ms, (p50: 4900 ms, p70: 5000, p90: 5200 ms, p99: 5400 ms), latency samples: 254480
5. check swarm health
Compatibility test for cb5d7c9615b937357dbede9439401be640fb7d17 ==> 2707a22233557a8ea1c12cc8b0340be109b16793 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking