Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compiler-v2] Use V2 in vm integration tests and remove V1 from prover #15716

Merged
merged 3 commits into from
Feb 12, 2025
Merged

[Compiler-v2] Use V2 in vm integration tests and remove V1 from prover #15716

merged 3 commits into from
Feb 12, 2025

Conversation

rahxephon89
Copy link
Contributor

@rahxephon89 rahxephon89 commented Jan 13, 2025 •
edited
Loading

Description

This PR:

  • uses compiler V2 in vm integration tests;
  • removes compiler V1 from prover;
  • removes corresponding v2_exp files from the prover crate.

How Has This Been Tested?

  1. existing tests pass;
  2. manually test aptos move prove.

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Move Prover

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Jan 13, 2025 •
edited
Loading

⏱️ 4m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-cargo-deny 2m 🟩 
check-dynamic-deps 2m 🟩 
general-lints 28s 🟩 
semgrep/ci 19s 🟩 
file_change_determinator 12s 🟩 
permission-check 3s 🟩 
permission-check 3s 🟩 
check-branch-prefix 1s 🟩 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@rahxephon89 Graphite App
Copy link
Contributor Author

rahxephon89 commented Jan 13, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rahxephon89 rahxephon89 changed the title fix v2 for vm integration tests [WIP] fix v2 for vm integration tests Jan 13, 2025
@rahxephon89 rahxephon89 force-pushed the teng/set-v2-for-more-crates branch from 0dd4bab to ac2e834 Compare February 8, 2025 05:45
@rahxephon89 rahxephon89 changed the title [WIP] fix v2 for vm integration tests [WIP] use V2 in vm integration tests and remove V1 from prover Feb 8, 2025
@rahxephon89 rahxephon89 changed the title [WIP] use V2 in vm integration tests and remove V1 from prover [WIP] Use V2 in vm integration tests and remove V1 from prover Feb 8, 2025
@rahxephon89 rahxephon89 force-pushed the teng/set-v2-for-more-crates branch 2 times, most recently from 3514754 to 640b0a1 Compare February 8, 2025 08:57
@rahxephon89 rahxephon89 changed the title [WIP] Use V2 in vm integration tests and remove V1 from prover [Compiler-v2] Use V2 in vm integration tests and remove V1 from prover Feb 8, 2025
@rahxephon89 rahxephon89 marked this pull request as ready for review February 8, 2025 09:01
@rahxephon89 rahxephon89 requested a review from vineethk February 8, 2025 09:01
@rahxephon89 rahxephon89 force-pushed the teng/set-v2-for-more-crates branch from 640b0a1 to 6317c73 Compare February 8, 2025 09:05
@rahxephon89 rahxephon89 force-pushed the teng/set-v2-for-more-crates branch from 6317c73 to 49629a1 Compare February 9, 2025 00:48
@rahxephon89 rahxephon89 mentioned this pull request Feb 9, 2025
Merged
22 tasks
@rahxephon89 rahxephon89 enabled auto-merge (squash) February 11, 2025 23:13
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 368644ccf8e3eb3b3e7d8e3b8fe7f8602ff291ea

two traffics test: inner traffic : committed: 12791.46 txn/s, submitted: 12793.67 txn/s, expired: 2.21 txn/s, latency: 3095.16 ms, (p50: 3000 ms, p70: 3200, p90: 3300 ms, p99: 12100 ms), latency samples: 4863840
two traffics test : committed: 99.98 txn/s, latency: 2659.01 ms, (p50: 2500 ms, p70: 2800, p90: 3100 ms, p99: 13700 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 0.907, avg: 0.591", "ConsensusProposalToOrdered: max: 0.319, avg: 0.312", "ConsensusOrderedToCommit: max: 0.736, avg: 0.615", "ConsensusProposalToCommit: max: 1.048, avg: 0.926"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.88s no progress at version 12329 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.66s no progress at version 2265913 (avg 0.66s) [limit 16].
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 368644ccf8e3eb3b3e7d8e3b8fe7f8602ff291ea

Compatibility test results for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 368644ccf8e3eb3b3e7d8e3b8fe7f8602ff291ea (PR)
Upgrade the nodes to version: 368644ccf8e3eb3b3e7d8e3b8fe7f8602ff291ea
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1607.63 txn/s, submitted: 1615.50 txn/s, failed submission: 7.73 txn/s, expired: 7.87 txn/s, latency: 1740.42 ms, (p50: 1500 ms, p70: 1900, p90: 2600 ms, p99: 4600 ms), latency samples: 145567
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1800.60 txn/s, submitted: 1806.48 txn/s, failed submission: 5.88 txn/s, expired: 5.88 txn/s, latency: 1660.01 ms, (p50: 1500 ms, p70: 1800, p90: 2400 ms, p99: 4200 ms), latency samples: 159201
5. check swarm health
Compatibility test for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 368644ccf8e3eb3b3e7d8e3b8fe7f8602ff291ea passed
Upgrade the remaining nodes to version: 368644ccf8e3eb3b3e7d8e3b8fe7f8602ff291ea
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1616.44 txn/s, submitted: 1620.66 txn/s, failed submission: 4.21 txn/s, expired: 4.21 txn/s, latency: 1880.14 ms, (p50: 1500 ms, p70: 2100, p90: 3300 ms, p99: 4600 ms), latency samples: 145760
Test Ok

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 368644ccf8e3eb3b3e7d8e3b8fe7f8602ff291ea

Compatibility test results for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 368644ccf8e3eb3b3e7d8e3b8fe7f8602ff291ea (PR)
1. Check liveness of validators at old version: 255673e8f2757ed8634a7d65d7aca11de7016cde
compatibility::simple-validator-upgrade::liveness-check : committed: 11643.68 txn/s, latency: 2642.92 ms, (p50: 2700 ms, p70: 2800, p90: 3000 ms, p99: 3800 ms), latency samples: 395140
2. Upgrading first Validator to new version: 368644ccf8e3eb3b3e7d8e3b8fe7f8602ff291ea
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3190.56 txn/s, latency: 9198.98 ms, (p50: 9900 ms, p70: 11200, p90: 11900 ms, p99: 12000 ms), latency samples: 70180
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3220.84 txn/s, latency: 10702.31 ms, (p50: 11700 ms, p70: 12000, p90: 12300 ms, p99: 12300 ms), latency samples: 126300
3. Upgrading rest of first batch to new version: 368644ccf8e3eb3b3e7d8e3b8fe7f8602ff291ea
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 3137.38 txn/s, latency: 9339.42 ms, (p50: 10000 ms, p70: 11400, p90: 12100 ms, p99: 12300 ms), latency samples: 68820
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3118.48 txn/s, latency: 10891.19 ms, (p50: 11900 ms, p70: 12300, p90: 12700 ms, p99: 12700 ms), latency samples: 121640
4. upgrading second batch to new version: 368644ccf8e3eb3b3e7d8e3b8fe7f8602ff291ea
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 6069.24 txn/s, latency: 5005.79 ms, (p50: 5700 ms, p70: 6400, p90: 6500 ms, p99: 6700 ms), latency samples: 113960
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 5945.41 txn/s, latency: 5713.45 ms, (p50: 6200 ms, p70: 6500, p90: 6700 ms, p99: 7000 ms), latency samples: 205820
5. check swarm health
Compatibility test for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> 368644ccf8e3eb3b3e7d8e3b8fe7f8602ff291ea passed
Test Ok

@rahxephon89 rahxephon89 merged commit 8876394 into main Feb 12, 2025
79 of 88 checks passed
@rahxephon89 rahxephon89 deleted the teng/set-v2-for-more-crates branch February 12, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vineethk vineethk vineethk approved these changes

@wrwg wrwg wrwg approved these changes

@gregnazario gregnazario Awaiting requested review from gregnazario gregnazario is a code owner

@banool banool Awaiting requested review from banool banool is a code owner

@davidiw davidiw Awaiting requested review from davidiw davidiw is a code owner

@movekevin movekevin Awaiting requested review from movekevin movekevin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahxephon89 @vineethk @wrwg