[move][natives] added batch bulletproof natives #15832
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjma
reviewed
Jan 28, 2025
| @@ -76,6 +76,7 @@ pub enum FeatureFlag { | |||
| GasPayerEnabled, | |||
| AptosUniqueIdentifiers, | |||
| BulletproofsNatives, | |||
| BulletproofsBatchNatives, | |||
There was a problem hiding this comment.
this has to go the end of the list so existing feature -> id mapping remain the same.
There was a problem hiding this comment.
oh maybe for this enum it doesn't matter... still recommend put it at the end though
zjma
reviewed
Jan 28, 2025
| @@ -129,6 +251,17 @@ module aptos_std::ristretto255_bulletproofs { | |||
| num_bits: u64, | |||
| dst: vector<u8>): bool; | |||
|
|
|||
| /// Aborts with `error::invalid_argument(E_DESERIALIZE_RANGE_PROOF)` if `proof` is not a valid serialization of a | |||
There was a problem hiding this comment.
It seems our move api accepts arbitrary bytes as RangeProof. In case of invalid serialization, better return false instead of aborting? just from API design perspective.
There was a problem hiding this comment.
Made E_DESERIALIZE_RANGE_PROOF deprecated
zjma
reviewed
Jan 28, 2025
| @@ -83,8 +93,10 @@ module aptos_std::ristretto255_bulletproofs { | |||
| ) | |||
| } | |||
|
|
|||
| /// Verifies a zero-knowledge range proof that the value `v` committed in `com` (as v * val_base + r * rand_base, | |||
| /// for some randomness `r`) satisfies `v` in `[0, 2^num_bits)`. Only works for `num_bits` in `{8, 16, 32, 64}`. | |||
| /// Verifies a zero-knowledge range proof for a batch of commitments `comms` (each of the form | |||
There was a problem hiding this comment.
accidentally copied from the batch version?
dovgopoly
force-pushed
the
distributedlab/batch-rp-natives
branch
from
cc4a57b to
b07b143
Compare
dovgopoly
changed the title
dovgopoly
requested review from
alinush,
rex1fernando,
davidiw,
movekevin and
wrwg
as code owners
dovgopoly
force-pushed
the
distributedlab/batch-rp-natives
branch
from
b07b143 to
49abefc
Compare
zjma
reviewed
Jan 29, 2025
| @@ -30,7 +30,7 @@ use std::collections::VecDeque; | |||
| pub mod abort_codes { | |||
| /// Abort code when deserialization fails (leading 0x01 == INVALID_ARGUMENT) | |||
| /// NOTE: This must match the code in the Move implementation | |||
| pub const NFE_DESERIALIZE_RANGE_PROOF: u64 = 0x01_0001; | |||
| pub const _NFE_DESERIALIZE_RANGE_PROOF: u64 = 0x01_0001; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist