Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a potential memory leak that occurs when a read error happens while processing the response body.
According to the net/http package documentation:
The caller must close the response body when finished with it.
Failing to close the response body on read errors can lead to resource leaks. This change ensures proper cleanup in such cases.
Test Plan
Testing this issue is not straightforward, as it depends on network failures. The read operation may return an error, as seen in the Go source reference.
One way to simulate this in a controlled environment is by setting an invalid Content-Length in the response header on the server side, forcing a read error:
This should trigger an unexpected EOF error when reading the response body.
Related Links
None.