Add serialization to the account classes #571
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhostWalker562
approved these changes
Nov 18, 2024
Comment on lines
+9
to
+11
| export interface DeserializableAccount<T> extends Deserializable<T> { | ||
| fromHex(hex: HexInput): T; | ||
| } |
There was a problem hiding this comment.
This seems to only be used in one test. Define it in the test file instead since this interface won't be that useful if it's not being inherited
| const anyKeyVariantOffset = deserializer.getOffset(); | ||
| deserializer.reset(offset); | ||
| switch (anyKeyVariant) { | ||
| case AnyPublicKeyVariant.Keyless: |
There was a problem hiding this comment.
I think it would be better if we can look into refactoring the accounts so that Keyless and Federated are SingleKeyAccount's and SingleKeyAccount can deserialize for the other two.
Since you added SingleKeySigner, maybe we can add the deserialization logic there and call that instead. This would be useful in the case that SingleKey's can also be used in new accounts (if ever)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds serialization to all the account classes. Clients that use Keyless will want to support the ability to add backup keys or turn the account into a multikey. This allows clients to cache the account agnostic of the actual signing method impl underneath. i.e., caching a
MultiKeyAccountandKeylessAccountcan work the same and useAccount.deserializeTest Plan
Added unit tests
Checklist
pnpm fmt?CHANGELOG.md?