Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skaji/relocatable-perl #29759

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

mackee
Copy link
Contributor

@mackee mackee commented Dec 10, 2024

skaji/relocatable-perl: self-contained, portable perl binaries

Check List

Description

  • In my project, there are cases where small maintenance scripts are written in Perl.
  • I want to manage all development tools uniformly using aqua.
  • relocatable-perl is a precompiled Perl runtime that can be used immediately after extraction, making it easy to adopt.
  • aqua already supports installing language runtimes such as node and go, so adding perl follows an existing precedent.

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Dec 10, 2024

Thank you for your contribution?

Didn't cmdx new work well?
We provide a command cmdx new to create a pull request, but some contributors don't use this command.
So we'd like to know the reason.
If there are any problem of cmdx new, we'd like to resolve it.

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Dec 10, 2024
@suzuki-shunsuke suzuki-shunsuke added this to the v4.272.1 milestone Dec 10, 2024
@suzuki-shunsuke suzuki-shunsuke changed the title Feat/skaji/relocatable perl feat: add skaji/relocatable-perl Dec 10, 2024
Comment on lines 3 to 6
- name: skaji/relocatable-perl
version: 5.36.0.0
version: 5.38.2.0
- name: skaji/relocatable-perl
version: 5.34.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change versions?

@suzuki-shunsuke
Copy link
Member

$ ls -1 /Users/shunsukesuzuki/.local/share/aquaproj-aqua/pkgs/github_release/github.com/skaji/relocatable-perl/5.34.1.0/perl-darwin-2level.tar.gz/perl-darwin-2level/bin
change-shebang
corelist
cpan
cpanm
enc2xs
encguess
h2ph
h2xs
instmodsh
json_pp
libnetcfg
perl
perl5.34.1
perlbug
perldoc
perlivp
perlthanks
piconv
pl2pm
pod2html
pod2man
pod2text
pod2usage
podchecker
prove
ptar
ptardiff
ptargrep
shasum
splain
streamzip
xsubpp
zipdetails

@suzuki-shunsuke suzuki-shunsuke merged commit 4748c1d into aquaproj:main Dec 10, 2024
16 checks passed
@suzuki-shunsuke
Copy link
Member

🎉 https://github.com/aquaproj/aqua-registry/releases/tag/v4.273.0

@mackee
Copy link
Contributor Author

mackee commented Dec 11, 2024

@suzuki-shunsuke
Thank you for the review, improvements, and release!

Didn't cmdx new work well?
We provide a command cmdx new to create a pull request, but some contributors don't use this command.
So we'd like to know the reason.
If there are any problem of cmdx new, we'd like to resolve it.

I referred to this article when contributing: https://zenn.dev/shunsuke_suzuki/books/aqua-handbook/viewer/contribute-to-standard-registry

After running cmdx t multiple times and confirming the results, I tried to use cmdx new. However, I received a message about uncommitted changes, so I made a commit.

When I ran cmdx new again, it attempted to execute git push origin feat/skaji/relocatable-perl. Since origin was set to aquaproj/aqua-registry, the push failed due to a lack of permissions.

I manually pushed to my forked repository, mackee/aqua-registry, and created a Pull Request from there.

I suspect I may have deviated from the intended workflow. I’d appreciate it if you could point out where I went wrong, as I’d like to use cmdx new properly next time.

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Dec 11, 2024

Thank you for your feedback.

When I ran cmdx new again, it attempted to execute git push origin feat/skaji/relocatable-perl. Since origin was set to aquaproj/aqua-registry, the push failed due to a lack of permissions.

Oh, I see. This one. cmdx new should suggest the document when the error occurs.

https://aquaproj.github.io/docs/products/aqua-registry/contributing/#cmdx-new-fails-to-push-a-commit-to-the-origin

@suzuki-shunsuke
Copy link
Member

Hmm. cmdx new should output the warning.

https://github.com/aquaproj/registry-tool/blob/0a624bfa835053271ac06f67505170b3320001d0/pkg/create-pr-new-pkg/api.go#L62-L72

	if err := commandStderr(ctx, io.MultiWriter(os.Stderr, stderr), "git", "push", "origin", branch); err != nil {
		if strings.Contains(stderr.String(), "returned error: 403") {
			logE.WithFields(logrus.Fields{
				"doc": "https://aquaproj.github.io/docs/products/aqua-registry/contributing#cmdx-new-fails-to-push-a-commit-to-the-origin",
			}).Warn(`you don't have the permission to push commits to the origin.
Please fork aquaproj/aqua-registry and fix the origin url to your fork repository.
For details, please see the document`)
		} else {
			return err
		}
	}

@mackee
Copy link
Contributor Author

mackee commented Dec 11, 2024

Got it, I understand now. I should have set upstream to this repository and origin to my forked repository. I should have paid closer attention to the documentation.

Additionally, when I executed the command, the git command prompted me for a GitHub username and password. At that point, I stopped the command with Ctrl-C. Unfortunately, this prevented the message suggesting the documentation from appearing.

Here is the log from when it happened:

$ cmdx new
+ set -eu

if ! bash scripts/new.sh; then
  bash scripts/ask_report.sh
fi

+ git add pkgs/skaji/relocatable-perl registry.yaml
+ git push origin feat/skaji/relocatable-perl
Username for 'https://github.com': ^CFATA[0018] aqua failed                                   env=darwin/arm64 error="execute a command: git push origin feat/skaji/relocatable-perl: signal: interrupt" program=aqua-registry registry_tool_version=0.3.1
If you face any problem, please create GitHub Issues to report the problem
https://github.com/aquaproj/aqua-registry/issues/new?assignees=&labels=support-request-of-dev-tool&projects=&template=02-support-request-dev-tool.yml
exit status 1

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Dec 11, 2024

Oh, I see. Thank you for sharing the log.
I'll resolve the issue.

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Dec 11, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [aquaproj/aqua-registry](https://github.com/aquaproj/aqua-registry) | minor | `v4.272.0` -> `v4.273.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>aquaproj/aqua-registry (aquaproj/aqua-registry)</summary>

### [`v4.273.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.273.0)

[Compare Source](aquaproj/aqua-registry@v4.272.0...v4.273.0)

[Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.273.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.273.0) | aquaproj/aqua-registry@v4.272.0...v4.273.0

#### 🎉 New Packages

[#&#8203;29759](aquaproj/aqua-registry#29759) [skaji/relocatable-perl](https://github.com/skaji/relocatable-perl): self-contained, portable perl binaries [@&#8203;mackee](https://github.com/mackee)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants