Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PowerShell/PowerShell #30540

Merged
merged 7 commits into from
Jan 6, 2025
Merged

Conversation

suzuki-shunsuke
Copy link
Member

@suzuki-shunsuke suzuki-shunsuke commented Jan 3, 2025

PowerShell/PowerShell: PowerShell for every system

$ aqua g -i PowerShell/PowerShell

Close #30538

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Jan 3, 2025
@suzuki-shunsuke suzuki-shunsuke added this to the v4.289.1 milestone Jan 3, 2025
@suzuki-shunsuke suzuki-shunsuke mentioned this pull request Jan 3, 2025
8 tasks
@suzuki-shunsuke
Copy link
Member Author

Unfortunately, aqua can't unarchive PowerShell's zip files for Windows well.

https://github.com/aquaproj/aqua-registry/actions/runs/12596569740/job/35108163653?pr=30540

ERRO[0018] install the package                           aqua_version=2.41.0 env=windows/arm64 error="reading file in zip archive: C:\\Users\\runneradmin\\AppData\\Local\\aquaproj-aqua\\pkgs\\github_release\\github.com\\PowerShell\\PowerShell\\v6.0.3\\PowerShell-6.0.3-win-arm64.zip\\Modules\\Microsoft.PowerShell.Archive\\1.1.0.0\\Microsoft.PowerShell.Archive.cat: making directory for file: mkdir C:\\Users\\runneradmin\\AppData\\Local\\aquaproj-aqua\\pkgs\\github_release\\github.com\\PowerShell\\PowerShell\\v6.0.3\\PowerShell-6.0.3-win-arm64.zip\\Modules\\Microsoft.PowerShell.Archive: The system cannot find the path specified." 

aqua uses mholt/archiver v3, but we need to consider migrating to mholt/archives.

@suzuki-shunsuke suzuki-shunsuke removed this from the v4.289.1 milestone Jan 3, 2025
@suzuki-shunsuke
Copy link
Member Author

@suzuki-shunsuke
Copy link
Member Author

suzuki-shunsuke commented Jan 4, 2025

Oh, my god.
I replaced mholt/archiver/v3 with mholt/archives, but the problem still occurs. 😢

https://github.com/aquaproj/aqua-registry/actions/runs/12607602450/job/35139155739?pr=30540

ERRO[0021] install the package
aqua_version=2.41.1-0 env=windows/arm64
error="extract files: handling file 38: Modules\\PackageManagement\\coreclr\\netcoreapp2.0\\Microsoft.PackageManagement.ArchiverProviders.dll:
create a directory: mkdir C:\\Users\\runneradmin\\AppData\\Local\\aquaproj-aqua\\pkgs\\github_release\\github.com\\PowerShell\\PowerShell\\v6.1.6\\PowerShell-6.1.6-win-arm64.zip\\Modules\\PackageManagement\\coreclr:
The system cannot find the path specified."
package_name=PowerShell/PowerShell 

@suzuki-shunsuke
Copy link
Member Author

suzuki-shunsuke commented Jan 5, 2025

Unfortunately, aqua v2.41.1-2 can't extract some files from PowerShell's zip files for Windows well, but it ignores the failure and continues the process.

https://github.com/aquaproj/aqua-registry/actions/runs/12615636366/job/35155936985?pr=30540

WARN[0001] create a directory                            error="mkdir C:\\Users\\runneradmin\\AppData\\Local\\aquaproj-aqua\\pkgs\\github_release\\github.com\\PowerShell\\PowerShell\\v6.0.2\\PowerShell-6.0.2-win-x64.zip\\Modules\\Microsoft.PowerShell.Archive: The system cannot find the path specified."

I'm not sure if PowerShell works well in this status.
If PowerShell depends on files which aqua can't extract, PowerShell wouldn't work.
But if PowerShell doesn't depend on them, PowerShell works well.
I don't have Windows Machine, so I can't test.

If you have Windows Machine, you can test:

Update aqua to v2.41.1-2

aqua upa v2.41.1-2

aqua.yaml:

registries:
  - type: standard
    ref: f5c683686de23d498dd5218e7493fbc00d6a5784
packages:
  - name: PowerShell/[email protected]

Install PowerShell:

aqua i

Run PowerShell

pwsh -v

@suzuki-shunsuke suzuki-shunsuke merged commit d85e866 into main Jan 6, 2025
18 checks passed
@suzuki-shunsuke suzuki-shunsuke deleted the feat/PowerShell/PowerShell branch January 6, 2025 02:37
@suzuki-shunsuke suzuki-shunsuke added this to the v4.291.1 milestone Jan 6, 2025
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jan 6, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [aquaproj/aqua-registry](https://github.com/aquaproj/aqua-registry) | minor | `v4.290.0` -> `v4.292.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>aquaproj/aqua-registry (aquaproj/aqua-registry)</summary>

### [`v4.292.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.292.0)

[Compare Source](aquaproj/aqua-registry@v4.291.0...v4.292.0)

[Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.292.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.292.0) | aquaproj/aqua-registry@v4.291.0...v4.292.0

#### 🎉 New Packages

[#&#8203;30540](aquaproj/aqua-registry#30540) [PowerShell/PowerShell](https://github.com/PowerShell/PowerShell): PowerShell for every system

#### Fixes

[#&#8203;30586](aquaproj/aqua-registry#30586) Dreamacro/clash: Remove the package

GitHub Repository isn't found

### [`v4.291.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.291.0)

[Compare Source](aquaproj/aqua-registry@v4.290.0...v4.291.0)

[Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.291.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.291.0) | aquaproj/aqua-registry@v4.290.0...v4.291.0

#### 🎉 New Packages

[#&#8203;30569](aquaproj/aqua-registry#30569) [jorgerojas26/lazysql](https://github.com/jorgerojas26/lazysql): A cross-platform TUI database management tool written in Go [@&#8203;wancup](https://github.com/wancup)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45MC40IiwidXBkYXRlZEluVmVyIjoiMzkuOTAuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PowerShell
1 participant