-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CIS OpenShift 1.6 Benchmark #1682
Open
deebhatia
wants to merge
17
commits into
aquasecurity:main
Choose a base branch
from
VoerEirAB:cis-openshift-1-6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,432
−6
Open
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
291074e
Add support for CIS Openshift 1.6
deebhatia b7b566d
Update all TCs in node.yaml
deebhatia f8d3aae
Update all TCs in etcd.yaml
deebhatia 2f50de2
Update all TCs in policies.yaml; fix command in rh-1.0 as well
deebhatia e510a33
Update all TCs in master.yaml
deebhatia 1a2de30
Fixes for node TCs
deebhatia 77a1f3a
Fixes for node and etcd TCs
deebhatia 3bce117
Revert incorrect changes done in rh-1.0 etcd TCs
deebhatia 1ae58e3
Add fixes in master TCs and docs
deebhatia ff650d0
Add fixes in node and etcd TCs
deebhatia 50a8736
Fix test
deebhatia 4984b11
Add job template for OCP
deebhatia c8d2de5
Add accidentally removed gke entry
deebhatia 308839d
Merge branch 'upstream-main' into cis-openshift-1-6
deebhatia 040c137
Add other resources needed for kube-bench pod
deebhatia 4ba6a0c
Add command with ocp benchmark selected
deebhatia 9a9adcd
Resolve linting issues in YAML file
deebhatia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add other resources needed for kube-bench pod
commit 040c137c9d1aae4763692cf88e2b46a2c69e47c8
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference between job-ocp.yaml and job.yaml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few additional volume mounts
"/etc/group"
and"/etc/passwd"
and service account token mountingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deebhatia Do we need to include the dependent ServiceAccount and RBAC resources in this YAML file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mozillazg, thanks for the suggestion. I have included all the resources needed for the job to work fine in same YAML file.