Fix symbol multi addrs #3802
Merged
Fix symbol multi addrs #3802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still missing the fix for #3653. Will be pushing soon. |
This was
linked to
issues
Jan 17, 2024
|
Note for reviewer: be aware that, due to some other duties before my last day, I won't have much, if any, time to change this PR too much (due to some other needs yet to be addressed). It seems that I was able to address and fix the issue and do some minor and good refactors. So, unless, you're willing to take ownership of the PR for yourself, I suggest that this is merged even if not perfect for your eyes (avoid nits and things alike), just so the work isn't lost (and any improvement can be done later with code already merged). My 2 cents only. |
This was referenced Jan 17, 2024
Merged
Follow recent decision about having "declarative" and "immutable" probes and add internal probe dependencies to each syscall event declaration.
Changes probes interface "tracing" type so kprobe and kretprobes can be attached using the kernel symbol addresses instead of names. This solves the problem when the symbol has multiple addresses and the kernel refuses the attachment (newer kernels) because of that. #3653 (comment) Fixes: #3653
Previous commits made kprobe/kretprobe attachments to be attached using the symbol addresses only. This is okay but events such as "bpf_attach" symbol name arguments are zeroed and tracee uses itself to test if bpf attachments were made. Thinking a bit more, there is no problem in having the bpf attachments using symbol names, as long as there aren't 2 addresses for the same symbol.
|
Passed all tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 68a961a (HEAD -> fix-symbol-multi-addrs)
Author: Rafael David Tinoco [email protected]
Date: Thu Jan 18 03:03:08 2024
commit 07d9593
Author: Rafael David Tinoco [email protected]
Date: Thu Jan 18 02:59:43 2024
commit 450d3d3
Author: Rafael David Tinoco [email protected]
Date: Wed Jan 17 14:45:07 2024
commit d9bdc0b
Author: Rafael David Tinoco [email protected]
Date: Wed Jan 17 10:36:44 2024
commit 8f0b203
Author: Rafael David Tinoco [email protected]
Date: Wed Jan 17 09:21:11 2024
commit 76890aa
Author: Rafael David Tinoco [email protected]
Date: Sat Jan 13 14:35:04 2024
commit 2f33192
Author: Rafael David Tinoco [email protected]
Date: Thu Jan 11 19:26:35 2024
commit 4b0bc93
Author: Rafael David Tinoco [email protected]
Date: Wed Jan 17 15:19:54 2024
commit 645fc4d
Author: Rafael David Tinoco [email protected]
Date: Wed Jan 17 15:27:10 2024