Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add lint for checks metadata #328

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Jan 27, 2025

This PR adds an invalid_metadata rule to help maintain consistency, avoid errors, and enforce metadata standards. This will help to avoid such mistakes: #327 (comment)

@nikpivkin nikpivkin marked this pull request as ready for review January 27, 2025 08:32
@nikpivkin nikpivkin requested a review from simar7 as a code owner January 27, 2025 08:32
@simar7
Copy link
Member

simar7 commented Jan 29, 2025

nice, should we also add a linter for naming of checks? Ref #327 (comment)

Maybe we allow only certain kinds of checks, based on providers: AVD-AWS-*, AVD-DS-*, etc. So that if there's one that we don't know, we'd have to add it to the lint rule first, if it is a legitimate addition of a new provider.

@simar7 simar7 added this pull request to the merge queue Jan 29, 2025
Merged via the queue into aquasecurity:main with commit ba50e6a Jan 29, 2025
6 checks passed
@nikpivkin nikpivkin deleted the lint-metadata branch January 30, 2025 03:57
@nikpivkin nikpivkin mentioned this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants