Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(APP-3912): Update Dialog and DialogAlert implementations #396

Merged
merged 7 commits into from
Jan 30, 2025

Conversation

cgero-eth
Copy link
Member

@cgero-eth cgero-eth commented Jan 29, 2025

Description

  • Update Dialog and DialogAlert implementations to reflect updates on designs
  • Fix missing storybook/jest dependency warning

Task: APP-3912

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Manually smoke tested the functionality locally
  • Confirmed there are no new warnings or errors in the browser console
  • Made the corresponding changes to the documentation
  • Added tests that prove my fix is effective or that my feature works
  • Updated the CHANGELOG.md file after the [UPCOMING] title and before the latest version
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisified
  • Confirmed there are no new warnings on automated tests
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the files changed in GitHub’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

@cgero-eth cgero-eth changed the title WIP feat(APP-3912): Update Dialog and DialogAlert implementations feat(APP-3912): Update Dialog and DialogAlert implementations Jan 29, 2025
@cgero-eth cgero-eth requested a review from a team January 29, 2025 17:22
Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking nice! Nice job on upping the accessibility. I just left the one comment on 'Close' button.

Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@cgero-eth cgero-eth merged commit 979f645 into main Jan 30, 2025
4 checks passed
@cgero-eth cgero-eth deleted the APP-3912-update-dialog-implementation branch January 30, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants