Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the EdgeChainApplication with the constructor and HTTP Response status. #126

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updated the EdgeChainApplication with the constructor and HTTP Response status. #126

wants to merge 2 commits into from

Commits on Jul 1, 2023

  1. Update EdgeChainApplication.java 

    1) Added constructor : It is better to use constructor injection rather than using Autowired annotation. It makes it testable. 

2) Make the pineconeservice as final.

3) Returning appropriate HTTP status code. 
     @ResponseStatus(HttpStatus.NO_CONTENT)
    @YogenderSha
    YogenderSha authored Jul 1, 2023
    Configuration menu
    Copy the full SHA
    2f606e1 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3 from YogenderSha/IssueConstruct 

    Update EdgeChainApplication.java
    @YogenderSha
    YogenderSha authored Jul 1, 2023
    Configuration menu
    Copy the full SHA
    442cdf0 View commit details
    Browse the repository at this point in the history