Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type safety for getT function #1184

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Add type safety for getT function #1184

merged 4 commits into from
Jan 26, 2024

Conversation

hichemfantar
Copy link
Contributor

@hichemfantar hichemfantar commented Jan 25, 2024 •
edited
Loading

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[ X ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)

  • refactor the TranslateFunction into its own interface
  • add support for getT

Which issue (if any) does this pull request address?
closes #1185

Is there anything you'd like reviewers to focus on?

@hichemfantar hichemfantar marked this pull request as draft January 25, 2024 15:45
@hichemfantar hichemfantar marked this pull request as ready for review January 25, 2024 15:52
@hichemfantar hichemfantar marked this pull request as draft January 25, 2024 16:02
@hichemfantar hichemfantar marked this pull request as ready for review January 25, 2024 16:35
aralroca
aralroca approved these changes Jan 25, 2024
View reviewed changes
Copy link
Owner

@aralroca aralroca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @hichemfantar !!

@aralroca aralroca merged commit 17df895 into aralroca:master Jan 26, 2024
6 checks passed
Repository owner deleted a comment from allcontributors bot Jan 26, 2024
Repository owner deleted a comment from allcontributors bot Jan 26, 2024
@aralroca
Copy link
Owner

@all-contributors add please @hichemfantar for code

@allcontributors allcontributors bot mentioned this pull request Jan 26, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@aralroca

I've put up a pull request to add @please! 🎉

@hichemfantar hichemfantar deleted the patch-1 branch January 26, 2024 01:36
@hichemfantar hichemfantar restored the patch-1 branch January 26, 2024 01:36
@hichemfantar
Copy link
Contributor Author

@allc add @hichemfantar

@all-contributors add please @hichemfantar for code

Hey, it looks like the bot added me incorrectly

@allcontributors allcontributors bot mentioned this pull request Jan 26, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@hichemfantar

I've put up a pull request to add @hichemfantar! 🎉

aralroca pushed a commit that referenced this pull request Apr 8, 2024
@hichemfantar @aralroca
Add type safety for getT function (#1184)
b63006f 
* Update type-safety.md

* Update next-translate.d.ts with new TranslateFunction interface

* Refactor translation types in next-translate.d.ts

* Refactor type safety in TranslateFunction
@aralroca
Copy link
Owner

@hichemfantar already in 3.0.0-canary.3

@hichemfantar hichemfantar deleted the patch-1 branch December 7, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aralroca aralroca aralroca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type safety for getT function
2 participants
@hichemfantar @aralroca