[BTS-1644] ResignLeadership + Wait #21401
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neunhoef
reviewed
Oct 28, 2024
| @@ -337,7 +344,28 @@ bool ResignLeadership::start(bool& aborts) { | |||
|
|
|||
| // Schedule shard relocations | |||
| if (!scheduleMoveShards(pending)) { | |||
| finish("", "", false, "Could not schedule MoveShard."); | |||
| LOG_TOPIC("d4473", DEBUG, Logger::SUPERVISION) | |||
There was a problem hiding this comment.
I would make this a "WARN" log level, according to our policy.
There was a problem hiding this comment.
Maybe "INFO", but it should show up in the logs whenever it happens in production, IMHO.
There was a problem hiding this comment.
I figured that it is enough to display this message when the job actually fails (see further down). Furthermore scheduleMoveShards already creates log messages which explain why it won't start yet.
maierlars
commented
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Added waitForInSync and waitForInSyncTimeout parameters to the resign leadership job. This allows the user to wait for a certain amount of time to make sure that there exist common in sync followers. Previously they were just ignored and could cause downtime.
Design Doc: https://github.com/arangodb/documents/pull/136