-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DE-664] Deprecating Batch API #279
Conversation
@@ -144,28 +133,3 @@ def test_batch_job_result_not_ready(db, col, docs): | |||
assert batch_db.commit() == [job] | |||
assert len(job.result()) == len(docs) | |||
assert extract("_key", col.all()) == extract("_key", docs) | |||
|
|||
|
|||
def test_batch_bad_state(db, col, docs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this test no longer makes sense with the current implementation, because we don't throw this exception anymore.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## main #279 +/- ##
==========================================
- Coverage 99.01% 98.64% -0.38%
==========================================
Files 26 26
Lines 3958 3981 +23
==========================================
+ Hits 3919 3927 +8
- Misses 39 54 +15
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://www.arangodb.com/docs/stable/http/batch-request.html
BatchDatabase
is still available, but it now uses aTreadPoolExecutor
internally.BatchDatabase
uses only one worker thread, essentially sending the requests sequentially. Feel free to set themax_workers
parameter to a higher value if you want to use multiple threads, but be aware that the requests will be sent in parallel, which may cause problems if you are using transactions.BatchDatabase
is used. This warning may be disabled by the user.Note that
{"foo": "bar"}
may be inserted after{"foo": "baz"}
in the following example:Documentation has been updated accordingly.