Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DE-756 | optimizeTopK View [3.12] #323

Merged
merged 7 commits into from
Apr 26, 2024
Merged

DE-756 | optimizeTopK View [3.12] #323

merged 7 commits into from
Apr 26, 2024

Conversation

aMahanna
Copy link
Member

@aMahanna aMahanna commented Feb 2, 2024

Add test case to validate that optimizeTopK is now a supported property in ArangoSearch Views

@aMahanna aMahanna marked this pull request as draft February 2, 2024 22:07
@aMahanna aMahanna changed the title wip: DE-756 wip: DE-756 [3.12] Feb 2, 2024
@aMahanna aMahanna changed the title wip: DE-756 [3.12] wip: DE-756 [3.11] Feb 8, 2024
@aMahanna aMahanna changed the title wip: DE-756 [3.11] wip: DE-756 | optimizeTopK View [3.11] Mar 8, 2024
@aMahanna aMahanna changed the title wip: DE-756 | optimizeTopK View [3.11] DE-756 | optimizeTopK View [3.11] Apr 26, 2024
@aMahanna aMahanna marked this pull request as ready for review April 26, 2024 14:13
Copy link
Collaborator

@alexbakharew alexbakharew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! optimizeTopK was introduced only for 3.12. That is why it is failing for 3.11

@aMahanna aMahanna changed the title DE-756 | optimizeTopK View [3.11] DE-756 | optimizeTopK View [3.12] Apr 26, 2024
@aMahanna
Copy link
Member Author

@alexbakharew thank you! resolved

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.22%. Comparing base (09ec84e) to head (8fd0b24).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #323   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files          26       26           
  Lines        4283     4283           
=======================================
  Hits         4207     4207           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@apetenchea apetenchea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aMahanna aMahanna merged commit a26e06a into main Apr 26, 2024
36 checks passed
@aMahanna aMahanna deleted the DE-756 branch April 26, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants