feedback

aranya-project · Dec 10, 2024 · 564b7c5 · 564b7c5
1 parent 5feb2a8
commit 564b7c5
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 129 deletions.
diff --git a/.github/actions/setup/action.yml b/.github/actions/setup/action.yml
@@ -1,47 +1,8 @@
 name: "Setup build tools"
 description: "Action for setting up build tools"
-inputs:
-  go-version:
-    description: "Go version"
-    required: true
-    default: "stable"
-  target:
-    description: "OS-arch target being compiled for (e.g., linux-arm64)"
 runs:
   using: "composite"
   steps:
-      # There is a bug in the version of GCC that ships with our
-      # arm64 runners that prevents BoringSSL from compiling. So,
-      # use Clang instead.
-      #
-      # TODO(eric): Reassess whether we still need these.
-    - name: Install arm64/amd64 system dependencies
-      run: |
-        set -x
-
-        lsb_release -a
-
-        sudo apt-get update -y
-        sudo apt-get install -y --no-install-recommends \
-          build-essential \
-          clang-14 \
-          clang-tools-14 \
-          cmake \
-          libc++-14-dev \
-          libc++abi-14-dev \
-          libclang-14-dev \
-          libclang1-14 \
-          llvm-14 \
-          llvm-14-dev \
-          lld-14 \
-          ninja-build \
-          pkg-config
-
-          echo "CC=$(which clang-14)" >> $GITHUB_ENV
-          echo "CXX=$(which clang-14)" >> $GITHUB_ENV
-          echo "LD=$(which lld-14)" >> $GITHUB_ENV
-      shell: bash
-
     #
     # Set up Rust
     #

diff --git a/.github/workflows/build-vxworks.yml b/.github/workflows/build-vxworks.yml
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -28,10 +28,9 @@ jobs:
   build-release:
     strategy:
       matrix:
-        runner: [ 
-          "ubuntu-latest",
-          "ubuntu2404-arm64-4core",
-        ]
+        runner:
+          - ubuntu-latest
+          - ubuntu2404-arm64-4core
     runs-on: ${{ matrix.runner }}
     steps:
       - uses: actions/checkout@v4

diff --git a/.github/workflows/correctness.yml b/.github/workflows/correctness.yml
@@ -26,10 +26,7 @@ concurrency:
 
 jobs:
   fmt:
-    strategy:
-      matrix:
-        runner: ["ubuntu-latest"]
-    runs-on: ${{ matrix.runner }}
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
 
@@ -39,10 +36,7 @@ jobs:
         run: cargo make check-fmt
 
   canaries:
-    strategy:
-      matrix:
-        runner: ["ubuntu-latest"]
-    runs-on: ${{ matrix.runner }}
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
 
@@ -52,10 +46,7 @@ jobs:
         run: cargo make check-canaries
 
   clippy:
-    strategy:
-      matrix:
-        runner: ["ubuntu-latest"]
-    runs-on: ${{ matrix.runner }}
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
 
@@ -65,10 +56,7 @@ jobs:
         run: cargo make clippy
 
   machete:
-    strategy:
-      matrix:
-        runner: ["ubuntu-latest"]
-    runs-on: ${{ matrix.runner }}
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
 
@@ -78,10 +66,7 @@ jobs:
         run: cargo make machete
 
   check:
-    strategy:
-      matrix:
-        runner: ["ubuntu-latest"]
-    runs-on: ${{ matrix.runner }}
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
 

diff --git a/.github/workflows/doc.yml b/.github/workflows/doc.yml
@@ -26,10 +26,7 @@ concurrency:
 
 jobs:
   doc:
-    strategy:
-      matrix:
-        runner: ["ubuntu-latest"]
-    runs-on: ${{ matrix.runner }}
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
 

diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -18,10 +18,7 @@ on:
 
 jobs:
   release:
-    strategy:
-      matrix:
-        runner: ["ubuntu-latest"]
-    runs-on: ${{ matrix.runner }}
+    runs-on: ubuntu-latest
     steps:
       - name: Create Release
         id: release
@@ -46,10 +43,7 @@ jobs:
     needs:
       - release
       - build
-    strategy:
-      matrix:
-        runner: ["ubuntu-latest"]
-    runs-on: ${{ matrix.runner }}
+    runs-on: ubuntu-latest
     steps:
       - name: Download doc artifacts
         uses: actions/download-artifact@v4

diff --git a/.github/workflows/security.yml b/.github/workflows/security.yml
@@ -26,10 +26,7 @@ concurrency:
 
 jobs:
   security-checks:
-    strategy:
-      matrix:
-        runner: ["ubuntu-latest"]
-    runs-on: ${{ matrix.runner }}
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
 

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -28,10 +28,9 @@ jobs:
   unit-tests:
     strategy:
       matrix:
-        runner: [ 
-          "ubuntu-latest",
-          "ubuntu2404-arm64-4core",
-        ]
+        runner:
+          - ubuntu-latest
+          - ubuntu2404-arm64-4core
     runs-on: ${{ matrix.runner }}
     steps:
       - uses: actions/checkout@v4