feat(crypto)!: make engine and rng shared #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdygert-spok
commented
Jan 7, 2025
| @@ -1056,7 +1056,7 @@ hmac_impl!(HmacSha384, "HMAC-SHA384", Sha384); | |||
| hmac_impl!(HmacSha512, "HMAC-SHA512", Sha512); | |||
|
|
|||
| /// A `HMAC_DRBG`-based CSPRNG. | |||
| pub struct HmacDrbg(br_hmac_drbg_context); | |||
| pub struct HmacDrbg(spin::Mutex<br_hmac_drbg_context>); | |||
There was a problem hiding this comment.
Had to add a mutex here.
|
I haven't thought about it much or looked at the PR in much depth, but I think it lgtm. |
|
fyi #34 |
Yeah that'll be fun to resolve :) Any thoughts on having mutexes on some rngs? |
It's fine. We only need a mutex for user space CSPRNGs, which we only use when absolutely forced to (FIPS or the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.